On 2016-11-16 04:57 +1030, Ron wrote:
> On Mon, Nov 14, 2016 at 06:46:23PM +0000, Wookey wrote:
> > Package: global
> > Version: 5.7.1-2
> > Severity: normal
> > 
> > I have a built kernel tree for 3.16.
> > 
> > running gtags on it gives a "directory stack over flow" error.
> > ~/debian/linux-3.16.7-ckt9$ gtags
> > gtags: directory stack over flow.
> 
> What are you actually building that source with?

I actually inherited this kernel tree (on a machine that needs a
patched kernel). But I expect it's built with standard debian
kernel-building tools (the chap who did it is not here to ask
currently); and the point is really, not how this was achieved, but
how global deals with it.
 
> Because this:
> 
> > Warning: symbolic link loop detected. 
> > 'debian/build/source_none/debian/build/source_none/' is ignored.

> Looks like a bug in your build scripts to be creating the symlink loops.
> I don't see anything like that in any of my kernel build trees ...

Yes, presumably something in the build has done that.
 
> Either way though, if you're actually seriously using this to index
> built kernel trees, then I'd recommend you look at the skip option
> for gtags configuration, to avoid having it uselessly crawl all over
> the build artifacts in the tree in any case, every time you run it
> to update the tags.
> 
> And I assume that if you do that, it does index the kernel for you
> just fine?

Probably, but you were asking for examples/evidence of where there was
actually a problem with global that was fixed in newer upstream
releases. This was one I came across.

> We could look at pulling the newer find code in if that's really a
> benefit to someone,

Given that I found this in the wild, clearly the code for detecting
symlink loops is a benefit, and that could be backported.

Obviously source trees shouldn't be doing that, but it will happen sometimes.

Wookey
-- 
Principal hats:  Linaro, Debian, Wookware, ARM
http://wookware.org/

Attachment: signature.asc
Description: Digital signature

Reply via email to