Dear Sean, On Sun, Dec 4, 2016 at 7:47 AM, Sean Whitton <spwhit...@spwhitton.name> wrote: >> > 1. The line "Only support emacs and xemacs" doesn't make sense (what >> > else would you be supporting?). What were you trying to say? >> >> Fixed. It's my simple mistake. I should say "Support emacs and xemacs." > > In that case, I think you should just delete that line altogether. > Normally, uploads of new packages have a changelog entry with only a > single line, closing the ITP.
Fixed. >> > 2. There is a Lintian error: >> > >> > E: verilog-mode: info-document-missing-dir-section >> > usr/share/info/verilog.info.gz >> >> You are right. I miss it out. It's fixed by >> debian/patches/fix-dircategory.patch. >> The patch is pull-requested to upstream: >> >> https://github.com/veripool/verilog-mode/pull/13 > > Good work. Please add a DEP-3 patch header, including a Forwarded: > field to show that the patch has been forwarded upstream. The patch already has been removed, because the upstream merged the patch. >> > 3. Some files are not GPL-3+. For example, >> > tests/auto_delete_whitespace.v. Please check every file's copyright >> > status and detail in d/copyright. >> >> The debian/copyright is updated. > > The copyright for Makefile is still not correct. Thanks for your advice. It's fixed. And also some lintian errors in debian/copyright are fixed. But I can't fix following a lintian error. Is it a issue on the side of lintian command? W: verilog-mode source: comma-separated-files-in-dep5-copyright paragraph at line 10 $ vi debian/copyright 5 Files: * 6 Copyright: 1996, Michael McNamara <m...@verilog.com> 7 2005, Wilson Snyder <wsny...@wsnyder.org> 8 License: GPL-3+ 9 10 Files: 0test.el, batch_prof.el, batch_test.el, batch_test.pl 11 Copyright: 2008-2013, Michael McNamara 12 2008-2013, Wilson Snyder 13 License: LGPL-2+ or Artistic > It has a function `verilog-lex' which might be useful to someone. > > Maybe it would be better to install it with the other *.el files, and > bytecompile it? I'm not sure what I was thinking when I suggested > installing it as an example. I added the "debian/verilog-mode.examples" file. > After you make changes, you need to run `dch -r` to update the timestamp > in d/changelog. Done. Best regards, -- Kiwamu Okabe at METASEPI DESIGN