Source: fastqtl Version: 2.184+dfsg-4 Severity: wishlist Tags: patch User: reproducible-bui...@lists.alioth.debian.org Usertags: fileordering X-Debbugs-Cc: reproducible-b...@lists.alioth.debian.org
Hi! While working on the "reproducible builds" effort [1], we have noticed that fastqtl could not be built reproducibly. There is already a patch that intends to fix a fileordering-related reproducibility issue. But it uses `sort -z', which expects a NULL-separated list. This is easily fixed by sorting without -z. Regards, Reiner [1]: https://wiki.debian.org/ReproducibleBuilds
diff --git a/debian/patches/03_Reproducible_builds.patch b/debian/patches/03_Reproducible_builds.patch index bfe3386..f2c8ff3 100644 --- a/debian/patches/03_Reproducible_builds.patch +++ b/debian/patches/03_Reproducible_builds.patch @@ -12,9 +12,9 @@ Forwarded: TODO -FILE_O=$(shell for file in `find src -name *.cpp`; do echo obj/$$(basename $$file .cpp).o; done) -FILE_H=$(shell find src -name *.h) -FILE_CPP=$(shell find src -name *.cpp) -+FILE_O=$(shell for file in `find src -name *.cpp | LC_ALL=C sort -z`; do echo obj/$$(basename $$file .cpp).o; done) -+FILE_H=$(shell find src -name *.h | LC_ALL=C sort -z) -+FILE_CPP=$(shell find src -name *.cpp | LC_ALL=C sort -z) ++FILE_O=$(shell for file in `find src -name *.cpp | LC_ALL=C sort`; do echo obj/$$(basename $$file .cpp).o; done) ++FILE_H=$(shell find src -name *.h | LC_ALL=C sort) ++FILE_CPP=$(shell find src -name *.cpp | LC_ALL=C sort) #default all: linux
