On 02.01.2017 12:04, Vincent Bernat wrote: > ❦ 2 janvier 2017 11:10 +0100, Sebastian Parschauer <s.parscha...@gmx.de> : >> See: >> https://github.com/sriemer/scanmem-debian/blob/source/scanmem_0.16-1.dsc > > This is not very convenient since I cannot use dget on this URL. But, I > have downloaded the source code successfully nonetheless. I am dropping > debian-release@ but keeping Emilio since he did a review before.
Thank you very much for downloading and reviewing! I've implemented the requested changes and updated the source branch. Please use the following to get the reworked source: dget https://raw.githubusercontent.com/sriemer/scanmem-debian/source/scanmem_0.16-1.dsc Please provide feedback if you're fine with it now. TIA > - d/control: don't depends on libc6-dev, this is part of > build-essential > - d/control: short descriptions should be something like: > > locate and modify a variable in a running process (library) > locate and modify a variable in a running process (development) > locate and modify a variable in a running process > > - d/control: a "This package contains the development files" should be > appended to the long description for libscanmem-dev > - d/control: a library should not suggest its dependencies > - d/dirs: empty, remove it > - d/docs: README is automatically added, if TODO is not interesting for > end-users, you may consider to remove the whole file (but you are > free to keep it) Okay, I've removed both files. > - d/libscanmem-dev.install: except if you have some users for that, > remove the .a. > - d/changelog: don't use urgency=high (this is for security updates), > keep urgency=low or urgency=medium (there is currently no difference > between them) > - d/copyright: the rule is last match wins, so you need to put the > "Files: *" section first I've implemented everything like requested and I've added a trivial upstream patch to fix an icon (replaced deprecated 'gtk-jump-to' with 'go-jump'). > Overall, I don't think that Emilio asked for a separate package for > libscanmem1. Since this is a private library, this can be kept in the > scanmem package. The only drawback would be that people using > gameconqueror will have to also install scanmem to get the lib. I don't > think you get a Lintian warning when doing that (since the library is > not installed in /usr/lib directly). But, it's up to you. Note that with > the two new binary packages, the upload will take some time since it > will be blocked in the NEW queue (expect at least a 1-week delay). It is intended and requested upstream to provide a separate libscanmem so that further tools can be built against it. We'll have to rework the public API any ways in v0.17. So I've dropped the separate libscanmem package for now to get the package uploaded faster. Lintian is still happy this way and the packages are working fine. Cheers, Sebastian
