Hi Tomasz,
On Fri, Jan 13, 2017 at 10:43:38PM +0100, Tomasz Buchert wrote:
> On 13/01/17 18:56, Guido Günther wrote:
> > On Fri, Jan 13, 2017 at 06:21:24PM +0100, Guido Günther wrote:
> > > Package: pristine-tar
> > > Version: 1.37
> > > Severity: normal
> > >
> > > Hi,
> > > importing lbzip2 fails with:
> > >
> > [...]
> >
> > libxfce4ui, nsis, thunar-volman, thunar, tumbler, xfce4-cpufreq-plugin,
> > xfce4-dev-tools, xfce4-dict, xfce4-weather-plugin fail with the same
> > error so I'm not filing separate reports.
> > Cheers,
> > -- Guido
>
> I didn't check all of these packages, but indeed they do not
> reproduce. However, note that these packages do not use pristine-tar
> (or gbp, if my sample was significant), so nobody ever tried to
> reproduce their tarballs with pristine-tar. :)
They do not now but they might in the future. My goal here was to make
gbp import-dsc <pkg>
work for all packages in the archive [0] for several reasons:
* Making it simple to work on random packages by doing a gbp import-dsc
(e.g. for security work or doing NMUs) - this requires an exact
tarball.
* Turning on pristine-tar by default in gbp as discussed at DC16[1]
* (Potentially) create a history of "gbp import-dscs --debsnap" where
others can fetch from (this doesn't require a reproducible tarball for
all versions as long as we let users know (e.g. for ancient versions)
pristine-tar actually already does an amazing job. We only have about 20
packages failing and the packages in this this bug form the largest
group (followed by some others that claim to have too big delta, these
are usually quiet big packages like chromium and I need to investigate
this separtely).
> The issue we have here is that it is impossible to "gbp import-dsc
> ..." a random package, because in general tarballs are messy. Correct
> me if I'm wrong, but it looks as if you don't intend to actually keep
> pristine-tar for anything more than temporary help to use gbp with the
> imported package?
We're also using pristine-tar in team maintained packages to have one
repository we can work from. This makes it a lot simpler for people not
that familiar with Debian to just git clone one thing and then have
everything at hand.
> If the answer is yes, then I propose to introduce a mode to
> pristine-tar that will: (1) try to import the given tarball using the
> standard machinery and if that fails (2) import the final tarball
> as-it-is. This sort of defeats the whole idea of pristine-tar, but may
> be a necessary evil for this sort of use and will not harm anyone if
> people won't use it to actually import tarballs into long-term package
> repositories. What do you think?
I intend to make "gbp import-dsc" just continue the import and warn the
user (#851287) when pristine-tar fails. For import-orig we already roll
back all changes and let the user retry without --pristine-tar.
So I don't think adding this mode to pristine-tar is really necessary,
if we can't create a long term stable tarball we'd better fail and let
the user cover up with e.g. by using origtgz.
Thanks a lot for a having a look at all the bugs I filed (and for
maintaining pristine-tar)!
Cheers,
-- Guido
[0]
http://lists.alioth.debian.org/pipermail/vcs-pkg-discuss/2017-January/000954.html
[1] http://lists.sigxcpu.org/pipermail/git-buildpackage/2016-July/000143.html
