On 14 Jan 2017, at 23:24, James Clarke <jrt...@debian.org> wrote: > On Sat, Jan 14, 2017 at 09:38:53PM +0000, Simon McVittie wrote: >> On Sat, 14 Jan 2017 at 19:50:17 +0000, Simon McVittie wrote: >>>> On Mon, Jan 9, 2017 at 2:21 PM, James Clarke <jrt...@debian.org> wrote: >>>>> I would guess there are some UI >>>>> interactions happening not on the main UI thread. >>> >>> I found a couple of places where this was done wrong. I'll send a >>> patch series soon. >> >> Try these? >> >> They seem to work here, but I didn't get this crash myself (in GNOME >> on Wayland with Gtk's standard Adwaita theme, if it matters) so I can't >> say whether they are a complete fix. > > I'm not sure why it's working for me and not you. That fixes the > segfault, but I still get: > >> Traceback (most recent call last): >> File "/usr/lib/python3/dist-packages/reportbug/ui/gtk2_ui.py", line 692, in >> validate >> value = self.get_value() >> File "/usr/lib/python3/dist-packages/reportbug/ui/gtk2_ui.py", line 1355, >> in get_value >> self.info_buffer.get_end_iter()) >> TypeError: Gtk.TextBuffer.get_text() takes exactly 4 arguments (3 given) > > After applying the attached patch on top of your series, I can get to > the editor, type, and progress to the final submission options screen. I > have yet to use it to report an actual bug, but it looks promising :)
It seems GetMultilinePage's get_value also has a call to get_text without the extra parameter, but a grep for GetMultilinePage only shows the class definition, with no uses... deletion candidate? From what I can tell, it was added in 3739eb89aa, but even then it wasn't being used by anything? Anyway, if it needs to stay, the extra True needs to be added to it too. Regards, James
