Hi Michael,

On Wed, Jan 11, 2017 at 11:34:52PM +0100, Michael Stapelberg wrote:
> Attached you can find a first stab at implementing this feature. I
> introduced a new protocol message to transfer base64-encoded arbitrary
> binary data.

the patch looks very nice. thanks for adding all the documentation
already.

> This can easily be used to transfer other files in the
> same spirit, should that become necessary in the future (it also seems
> like the clean thing to do, even if we’re just talking about a single
> file). 

nice!

> The files are then made available at
> /<section>/aux/<package>_<version>/<filename>, e.g.
> /sid/aux/libva1_1.7.3-2/alternatives.tar.gz.

fine in principle, except this is part of the three concerns I have
about the patch:

- "aux" is maybe a bit too short (as a directory name), maybe not :)
- the option --auxdir is good, but in the current patches this is not
  seperated from --record-alternatives-in-auxdir or whatever that option
  to enable alternatives collection should be called. Not sure about the
  name for that option but you'll get the idea…
- please also add a debian/changelog entry…


-- 
cheers,
        Holger

Attachment: signature.asc
Description: Digital signature

Reply via email to