Control: retitle -1 xymon-client: udev Predictable Network Interface Names are
not properly recognized
Hi David,
david wrote:
> Based on all this, I believe the bug was incorrectly filed and
> should be listed as something similar to "udev Predictable Network
> Interface Names are not properly recognized".
Thanks for these details. Just in time as 4.3.28 was released just a
few hours ago and one thing left on the TODO list for the upload is to
fix this issue.
> It's also worth mentioning that the new net-tools doesn't seem to
> impact this issue, either. That was a false suspicion.
I can confirm that false suspicion since I've now found the place
where all this happens:
xymond/rrd/do_ifstat.c, starting at line 21:
19 /* eth0 Link encap: */
20 /* RX bytes: 1829192 (265.8 MiB) TX bytes: 1827320 (187.7 MiB */
21 static const char *ifstat_linux_exprs[] = {
22 "^([a-z0-9]+(_[0-9]+)?:*|lo:?)\\s",
23 "^\\s+RX bytes:([0-9]+) .*TX bytes.([0-9]+) ",
24 "^\\s+RX packets\\s+[0-9]+\\s+bytes\\s+([0-9]+) ",
25 "^\\s+TX packets\\s+[0-9]+\\s+bytes\\s+([0-9]+) "
26 };
Note that the trailing colon is already supported in line 22. That
clearly marks our initial suspicion as wrong. Even later:
216 /* Strip off the last character if it
is a colon (:) */
217 if (ifname[strlen(ifname)-1] == ':')
ifname[strlen(ifname)-1] = '\0';
But then again that line 22 looks it should just accept names like
"wlp4s0". Will have to dig a little bit deeper.
Regards, Axel
--
,''`. | Axel Beckert <[email protected]>, http://people.debian.org/~abe/
: :' : | Debian Developer, ftp.ch.debian.org Admin
`. `' | 4096R: 2517 B724 C5F6 CA99 5329 6E61 2FF9 CD59 6126 16B5
`- | 1024D: F067 EA27 26B9 C3FC 1486 202E C09E 1D89 9593 0EDE
