Package: release.debian.org Severity: normal User: release.debian....@packages.debian.org Usertags: unblock
Hi release team, please unblock package lasagne. The new upload closes RC bug #834910. Please see the attached debdiff for changes. Thank you, Daniel Stender unblock lasagne/0.1+git20160728.8b66737-2 -- System Information: Debian Release: stretch/sid APT prefers testing APT policy: (500, 'testing') Architecture: amd64 (x86_64) Kernel: Linux 4.8.0-2-amd64 (SMP w/4 CPU cores) Locale: LANG=de_DE.utf8, LC_CTYPE=de_DE.utf8 (charmap=UTF-8) Shell: /bin/sh linked to /bin/dash Init: systemd (via /run/systemd/system)
diff -Nru lasagne-0.1+git20160728.8b66737/debian/changelog lasagne-0.1+git20160728.8b66737/debian/changelog --- lasagne-0.1+git20160728.8b66737/debian/changelog 2016-08-19 18:46:45.000000000 +0200 +++ lasagne-0.1+git20160728.8b66737/debian/changelog 2017-02-09 12:25:30.000000000 +0100 @@ -1,3 +1,10 @@ +lasagne (0.1+git20160728.8b66737-2) unstable; urgency=medium + + * Use inspect.signature instead of inspect.getargspec if possible + (Closes: #834910) [Ole Streicher]. + + -- Daniel Stender <sten...@debian.org> Thu, 09 Feb 2017 12:25:30 +0100 + lasagne (0.1+git20160728.8b66737-1) unstable; urgency=medium * Initial release (Closes: #818641). diff -Nru lasagne-0.1+git20160728.8b66737/debian/patches/remove-deprecated.patch lasagne-0.1+git20160728.8b66737/debian/patches/remove-deprecated.patch --- lasagne-0.1+git20160728.8b66737/debian/patches/remove-deprecated.patch 1970-01-01 01:00:00.000000000 +0100 +++ lasagne-0.1+git20160728.8b66737/debian/patches/remove-deprecated.patch 2017-02-09 12:25:24.000000000 +0100 @@ -0,0 +1,42 @@ +Author: Ole Streicher <oleb...@debian.org> +Description: Use inspect.signature instead of inspect.getargspec if possible + inspect.getargspec is deprectated in Python 3.5 and causes a warning. + The deprecation warning caused failures in test_get_output_with_unused_kwarg and + test_get_output_with_no_unused_kwarg. +Bug: https://bugs.debian.org/834910 +Forwarded: https://github.com/Lasagne/Lasagne/pull/797 +--- a/lasagne/layers/helper.py ++++ b/lasagne/layers/helper.py +@@ -1,6 +1,6 @@ + from collections import deque + from difflib import get_close_matches +-from inspect import getargspec ++import inspect + from itertools import chain + from warnings import warn + +@@ -9,6 +9,15 @@ + + from .. import utils + ++def getargs(callable): ++ try: ++ pars = inspect.signature(callable).parameters ++ return (list(pars.keys()), ++ tuple(p.default for p in pars.values() ++ if p.default is not p.empty)) ++ except AttributeError: ++ name, _, _, defaults = inspect.getargspec(callable) ++ return (name, defaults) + + __all__ = [ + "get_all_layers", +@@ -190,7 +199,7 @@ + % layer) + all_outputs[layer] = layer.get_output_for(layer_inputs, **kwargs) + try: +- names, _, _, defaults = getargspec(layer.get_output_for) ++ names, defaults = getargs(layer.get_output_for) + except TypeError: + # If introspection is not possible, skip it + pass diff -Nru lasagne-0.1+git20160728.8b66737/debian/patches/series lasagne-0.1+git20160728.8b66737/debian/patches/series --- lasagne-0.1+git20160728.8b66737/debian/patches/series 2016-08-18 20:59:52.000000000 +0200 +++ lasagne-0.1+git20160728.8b66737/debian/patches/series 2017-02-09 12:15:56.000000000 +0100 @@ -1,2 +1,3 @@ pytest-no-cov-pep8.patch use-mathjax-package.patch +remove-deprecated.patch diff -Nru lasagne-0.1+git20160728.8b66737/debian/rules lasagne-0.1+git20160728.8b66737/debian/rules --- lasagne-0.1+git20160728.8b66737/debian/rules 2016-08-18 20:59:52.000000000 +0200 +++ lasagne-0.1+git20160728.8b66737/debian/rules 2017-02-09 12:15:56.000000000 +0100 @@ -8,7 +8,7 @@ dh $@ --with python2,python3,sphinxdoc --buildsystem=pybuild override_dh_auto_test: - PYBUILD_SYSTEM=custom PYBUILD_TEST_ARGS="{interpreter} -m pytest -v -rs lasagne/" dh_auto_test || true # 2 fails with Python 3.5 remain + PYBUILD_SYSTEM=custom PYBUILD_TEST_ARGS="{interpreter} -m pytest -v -rs lasagne/" dh_auto_test override_dh_auto_install: dh_auto_install
