Dear Sean, >I've just reviewed revision 5e12184 of your packaging repository, and >compared it against the points of my previous review. I'm happy to see >that almost everything was handled. I also built and installed the >package and tried out 4Pane. > >There are two remaining issues. > >1) You need to run `dch -r` so that the timestamp in the changelog is >after all the changes you have made. You have modified this package >since December! Try to get into the habit of committing a `dch -r` >change before each upload/review.
Sorry, I'll try to remember. >2) Your ChangeToAutomakeBuild.patch does not actually resolve the DFSG >issues because the files are still present in the upstream tarball, >which can't be distributed by the Debian mirrors. A copy of those files >is also present in the .patch file... > >The usual solution is to repack the upstream tarball to remove the >files, and append '+dfsg' to the upstream version. Since you are the >upstream author, you could just make a 4.1 release of 4pane not >containing those files. Whichever one would be more convenient for you. I see. That not only makes sense, but is also more elegant than patching. As well as bakefile-related files, I've also removed several bitmaps of unknown licence as presumably the above paragraphs would apply to them too. I've uploaded a +dfsg tarball to the 4Pane website and altered d/watch to download it. uscan and lintian seem happy, so hopefully I've done this correctly. Regards, David Hart
