Hello Daniel, On Mon, Mar 13, 2017 at 04:26:43PM -0400, Daniel Kahn Gillmor wrote: > Control: found 855334 1:45.8.0-1 > Control: tags 855334 + patch > > Passing multiple arguments to Thunderbird is still a problem in 45.8.0-1 > except that the failures are silent now :/
I don't wanted to wait on this issue as the otherwise broken script was a more conflicting thing and make the upload really grave. > On Sun 2017-03-12 12:00:53 -0400, Guido Günther wrote: > > > FWIW git-pbuilder has code to mangle options to pass them on to > > pbuilder (which is a very similar problem) and uses a shell array. You > > can rip out the code from there. > > cool, thanks for the pointer! > > I note that git-pbuilder is also a bash script, and it has a > shell_quote() function which looks much more complex than just using the > builtin printf's %q expansion, and git-pbuilder is also trying to mix > explicitly-set external variables with internally-generated variables, > which is more complex than what /usr/bin/thunderbird needs. > > I think the simplest thing is to just replace the declaration, > accumulation, and use entirely with array usage, and leave it at that. > > I've included a patch here that appears to do the right thing for me. Thanks for looking again into the a script. I had modified the warpper script in the between time a little bit different. I've done some more effort to catch some special arguments and get them savely prepared to the binary call. There are for sure more than one way to get the argument passing done. https://anonscm.debian.org/cgit/pkg-mozilla/icedove.git/commit/?h=debian/sid&id=c2a1d77dd811ffd758f8306a71629e28490bc628 I have tested the script with these changes a lot and every argument is now going correctly to the starting call of the TB binary, also given arguments that are unknown for TB. But that's correct in my eyes as we only want to filter out the argument for controling the wrapper. I'm of course open for improvements. Given Christoph is solving #856185 he is planning to upload a version -2 probably within the next hours. https://bugs.debian.org/856185 Regards Carsten
