On Sun, Mar 26, 2017 at 04:03:47PM +0200, Martin Quinson wrote: > Hello, > > it took me a while, but I had a look at your code, at least. Your new > module seem very reasonnable to me, thank you. > > The thing is that I don't quite understand the tests. Could you please > give your files sensible names? Have a look at how the AsciiDoc tests > are organized: they are in t/data-30. You have a bunch of source > files, one per feature set. And for each file you have a out and po > files. All of these files are listed in t/30-asciidoc.t > > So you just have to "cp t/30-asciidoc.t t/31-rubydoc.t", edit > t/31-rubydoc.t to change the asciidoc tests into rubydoc ones. > > if you have any issue with integrating your tests, I can certainly do > that, but I'd need you to give sensible names to the test files, please. > > Sorry for the latency, I'll try to be more responsive in the future. >
In addition, you'll need the attached patch to integrate your module to po4a and play with the test directory. It assumes that your Rd.pm file is renamed as lib/Locale/Po4a/RubyDoc.pm (as it should). Thanks for your time and patience, Mt. -- Computers make very fast, very accurate mistakes.
diff --git a/lib/Locale/Po4a/Chooser.pm b/lib/Locale/Po4a/Chooser.pm
index 3b2a10ca..95433aa4 100644
--- a/lib/Locale/Po4a/Chooser.pm
+++ b/lib/Locale/Po4a/Chooser.pm
@@ -39,6 +39,8 @@ sub new {
$modname = 'TeX';
} elsif ($module eq 'asciidoc') {
$modname = 'AsciiDoc';
+ } elsif ($module eq 'Rd' || $module eq 'rubydoc') {
+ $modname = 'RubyDoc';
} else {
$modname = ucfirst($module);
}
@@ -69,6 +71,7 @@ sub list {
."\n - ".gettext("latex: LaTeX format.")
."\n - ".gettext("man: Good old manual page format.")
."\n - ".gettext("pod: Perl Online Documentation format.")
+ ."\n - ".gettext("rubydoc: Ruby Documentation format.")
."\n - ".gettext("sgml: either DebianDoc or DocBook DTD.")
."\n - ".gettext("texinfo: The info page format.")
."\n - ".gettext("tex: generic TeX documents (see also latex).")
@@ -129,6 +132,7 @@ L<Locale::Po4a::KernelHelp(3pm)>,
L<Locale::Po4a::LaTeX(3pm)>,
L<Locale::Po4a::Man(3pm)>,
L<Locale::Po4a::Pod(3pm)>,
+L<Locale::Po4a::RubyDoc(3pm)>,
L<Locale::Po4a::Sgml(3pm)>,
L<Locale::Po4a::TeX(3pm)>,
L<Locale::Po4a::Texinfo(3pm)>,
@@ -147,7 +151,7 @@ L<Locale::Po4a::Wml(3pm)>.
=head1 COPYRIGHT AND LICENSE
-Copyright 2002,2003,2004,2005,2014 by SPI, inc.
+Copyright 2002,2003,2004,2005,2014,2017 by SPI, inc.
This program is free software; you may redistribute it and/or modify it
under the terms of GPL (see the COPYING file).
signature.asc
Description: PGP signature
