Quoting Antonio Terceiro (2017-03-29 03:16:32) > On Tue, Mar 28, 2017 at 10:20:30PM +0200, Jonas Smedegaard wrote: >> Debian use /usr/share/compass as _shared_ location for Compass >> libraries - upstream has no such default location. >> >> Your reasoning is the equivalent of installing C libraries in >> /usr/lip and arguing that one should always explicitly feed the >> compiler the path (not rely on default path being /usr/lib on Debian >> systems). > > I disagree with your analogy. There is a set of well known places > where you can put libraries so that compilers find them automatically, > and those are known to _everyone_ that does or use libraries, not only > in Debian. > > In this case, there is a convention that only exists in Debian, and > AFAICT forces every single package to be patched. Is there any > movement in the direction of having this adopted upstream?
Compass does not dictate which locations should be looked up by default but certainly provides the mechanism for default lookup paths - and that mechanism is used in the Debian packaging of Compass. You may try argue that compass-bootstrap-sass-plugin provides a _private_ library, not intended for general use. But that makes little sense to me. > That said, I am willing to support this, but I don't agree it's an RC > issue. > > I tried changing /usr/share/compass/frameworks/bootstrap-sass to > /usr/share/compass/frameworks/bootstrap as you said, but that doesn't > exactly make it work: [...] > Any ideas? Attached patch is what I use. It might not apply as-is - I use it together with a couple other patches to address the other issues mentioned initially in this bugreport about the odd packaging into two binary packages. Would you perhaps be interested in moving this package to the Sass team, and maintain the package there? That helps coordinate the interaction between the Sass/Compass libraries (Compass is dead upstream, so there will likely soon be some restructuring to relax dependencies). I can also offer to take over maintenance of this package, if you don't mind that move but are not interested in joining that other team. - Jonas -- * Jonas Smedegaard - idealist & Internet-arkitekt * Tlf.: +45 40843136 Website: http://dr.jones.dk/ [x] quote me freely [ ] ask before reusing [ ] keep private
Description: Use shared assets path untied from Ruby library path. Author: Antonio Terceiro <terce...@debian.org> Author: Jonas Smedegaard <d...@jones.dk> Origin: vendor Forwarded: not-needed Last-Update: 2017-03-19 --- a/lib/bootstrap-sass.rb +++ b/lib/bootstrap-sass.rb @@ -32,7 +32,7 @@ end def assets_path - @assets_path ||= File.join gem_path, 'assets' + @assets_path ||= '/usr/share/compass/frameworks/bootstrap-sass' end # Environment detection helpers @@ -63,9 +63,9 @@ ::Compass::Frameworks.register( 'bootstrap', :version => Bootstrap::VERSION, - :path => gem_path, + :path => assets_path, :stylesheets_directory => stylesheets_path, - :templates_directory => File.join(gem_path, 'templates') + :templates_directory => File.join(assets_path, 'templates') ) end --- a/lib/bootstrap-sass/engine.rb +++ b/lib/bootstrap-sass/engine.rb @@ -3,7 +3,7 @@ class Engine < ::Rails::Engine initializer 'bootstrap-sass.assets.precompile' do |app| %w(stylesheets javascripts fonts images).each do |sub| - app.config.assets.paths << root.join('assets', sub).to_s + app.config.assets.paths << root.join(sub).to_s end app.config.assets.precompile << %r(bootstrap/glyphicons-halflings-regular\.(?:eot|svg|ttf|woff2?)$) end --- a/templates/project/manifest.rb +++ b/templates/project/manifest.rb @@ -8,7 +8,7 @@ # Copy JS and fonts manifest = Pathname.new(File.dirname(__FILE__)) -assets = File.expand_path('../../assets', manifest) +assets = File.expand_path('../..', manifest) {:javascript => 'javascripts', :font => 'fonts' }.each do |method, dir|
signature.asc
Description: signature