On Thursday, May 18 2017, Boyuan Yang wrote:

> 在 2017年5月18日星期四 +08 下午12:07:41,SJ Zhu 写道:
>> On Thu, May 18, 2017 at 11:59:36AM +0800, Boyuan Yang wrote:
>> > There are some problems: this packaging uses upstream source code directly
>> > from from Git repository, not the tarball upstream released on https://
>> > pagures.io.
>> 
>> Hi,
>> I import the source by `git archvie` and remove the minified js,
>> then import it to upstream branch like what sergiodj did.
>> 
>> PS. I think I forget to remove some files which filename is not matched
>> by "*.min.js"

Thanks for taking a look at the package and fixing some of the issues.

I'm now back from my vacation and can dedicate some time to pagure
again.

> I have several understandings on it:
>
> Option 1
> ------------
>
> * Will not use any bundled javascript libraries, no matter minified or not
> * Will depend on corresponding libjs-* packages and make symlinks to provide 
> removed javascript libraries
> * If that package does not exist, package them first

This is what I was trying to do from the beginning.  I packaged some
libjs-* packages last year, but not all of them.  Also, I was following
upstream and noticed that the they add extra dependencies/bump versions
of existing dependencies indiscriminately, which is not very good for
us.  I was trying to talk with upstream and come up with a saner
approach for this, but got sidetracked.

> Option 2
> ------------
>
> * Only minified javascripts are not acceptable
> * Will use tools like yui-compressor to generate minified js files without 
> using 
> libjs-* packages
> * Write d/copyright for unminified js files

> Option 3
> -------------
>
> * An mixture of 1 & 2
> * Use libjs-* if that lib has been packaged in Debian
> * If not packaged, use non-minified version and run processor to generate 
> minified js files

After a while, I was starting to wonder whether it would make sense to
follow this approach.  I noticed that packaging all the JS deps would
take a long time (at the time we didn't have Grunt packaged for Debian).

Anyway, I believe it may be possible to pursue the first option now that
Grunt is available.

-- 
Sergio
GPG key ID: 237A 54B1 0287 28BF 00EF  31F4 D0EB 7628 65FC 5E36
Please send encrypted e-mail if possible
http://sergiodj.net/

Attachment: signature.asc
Description: PGP signature

Reply via email to