On Sat, Apr 22, 2017 at 06:46:34PM -0500, Jason Crain wrote: > On Tue, Mar 28, 2017 at 01:36:45PM -0400, Daniel Gnoutcheff wrote: > > 1. Click on an empty day to add a new event > > 2. Click "Edit Details..." > > 3. Click "Done" > > > > Result: gnome-calendar segfaults. > > This crash is fixed upstream with the attached patch.
Can this be fixed for stretch? This bug means that trying to create a new event and using the "Edit Details..." button in gnome-calendar will make it crash. I've attached a debdiff (patch copied from upstream) that fixes this in the unstable version. Since gnome-calendar has different versions in testing and unstable, I think this would require going through testing-proposed-updates. If a maintainer agrees with the patch and uploads it to unstable, I'll create a release.debian.org bug to ask for approval to also upload to testing-proposed-updates.
diff -Nru gnome-calendar-3.22.4/debian/changelog gnome-calendar-3.22.4/debian/changelog --- gnome-calendar-3.22.4/debian/changelog 2017-03-29 16:00:23.000000000 -0500 +++ gnome-calendar-3.22.4/debian/changelog 2017-05-28 10:31:05.000000000 -0500 @@ -1,3 +1,10 @@ +gnome-calendar (3.22.4-2) unstable; urgency=high + + * Add debian/patches/0003-set-edit-dialogs-event-to-NULL-after-saving.patch: + fix crash when creating a new event. (Closes: #858924) + + -- Jason Crain <ja...@inspiresomeone.us> Sun, 28 May 2017 10:31:05 -0500 + gnome-calendar (3.22.4-1) unstable; urgency=medium * New upstream release. diff -Nru gnome-calendar-3.22.4/debian/patches/0003-set-edit-dialogs-event-to-NULL-after-saving.patch gnome-calendar-3.22.4/debian/patches/0003-set-edit-dialogs-event-to-NULL-after-saving.patch --- gnome-calendar-3.22.4/debian/patches/0003-set-edit-dialogs-event-to-NULL-after-saving.patch 1969-12-31 18:00:00.000000000 -0600 +++ gnome-calendar-3.22.4/debian/patches/0003-set-edit-dialogs-event-to-NULL-after-saving.patch 2017-05-28 10:31:05.000000000 -0500 @@ -0,0 +1,39 @@ +From: Yash Singh <yashdev...@gmail.com> +Date: Fri, 10 Mar 2017 17:58:52 +0530 +Subject: window: set edit dialog's event to NULL after saving + +Earlier the app used to crash when a new event was added using the +'Edit Details' buttion/dialog. This was happening because edit dialog's +event was set to NULL before the event was being stored in the calendar +through the 'edit_dialog' and hence the app was crashing. + +This patch fixes the above-mentioned issue by saving the event before +setting the edit dialog's event to NULL. + +Origin: upstream, https://git.gnome.org/browse/gnome-calendar/commit/?id=6f87ada70dbeae71e3428ee3a63f79b8c918f121 +Bug: https://bugzilla.gnome.org/779733 +Bug-Debian: https://bugs.debian.org/858924 +Last-Update: 2017-05-28 +--- + src/gcal-window.c | 3 ++- + 1 file changed, 2 insertions(+), 1 deletion(-) + +--- a/src/gcal-window.c ++++ b/src/gcal-window.c +@@ -1102,7 +1102,6 @@ + event = gcal_edit_dialog_get_event (edit_dialog); + view = GCAL_VIEW (window->views[window->active_view]); + +- gcal_edit_dialog_set_event (edit_dialog, NULL); + gtk_widget_hide (GTK_WIDGET (dialog)); + + switch (response) +@@ -1149,6 +1148,8 @@ + break; + + } ++ ++ gcal_edit_dialog_set_event (edit_dialog, NULL); + } + + static void diff -Nru gnome-calendar-3.22.4/debian/patches/series gnome-calendar-3.22.4/debian/patches/series --- gnome-calendar-3.22.4/debian/patches/series 2016-09-14 17:30:46.000000000 -0500 +++ gnome-calendar-3.22.4/debian/patches/series 2017-05-28 10:22:32.000000000 -0500 @@ -1,2 +1,3 @@ 0001-Hide-GOA-sources-on-Unity.patch 0002-Spawn-Ubuntu-s-credentials-panel-instead-of-the-GOA-.patch +0003-set-edit-dialogs-event-to-NULL-after-saving.patch