Am 04.07.2017 um 17:10 schrieb Emmanuel Bourg: > Le 4/07/2017 à 14:08, Markus Koschany a écrit : > >> Maybe let's start with an upload to >> experimental and we try it on some guinea pig javahelper packages first. > > Why not but it looks like a lot of efforts for no gain (besides the > satisfaction of compiling with a modern encoding, but that's not a > feature with a visible impact for our users or on the maintenance). I'd > rather focus on fixing the Java 9 issues.
I think it is very important that the encoding is handled consistently by all build tools. I wanted to fix this for a while now because too many times I had to specify UTF-8 explicitly and the build system tried to use ASCII. UTF-8 is the de-facto standard encoding in Debian and should be a first class citizen in Debian Java too. Thus said I don't want to force this on you. Just give me some hints where I have to look in the javahelper package and I experiment with the available options myself. >> Maybe the logic should be: IF NOT EXIST property encoding in pom.xml or >> (IF EXIST debian/maven.properties AND debian/maven.properties CONTAINS >> STRING project.build.sourceEncoding) SET encoding to UTF-8 > > For Maven projects this will fix nothing. If the project has UTF-8 > encoded files and doesn't define project.build.sourceEncoding, the > package already FTBFS on the builders and we should be aware of it. > > I think our Maven based packages are fine, they either have: > - the source encoding defined in pom.xml > - the source encoding defined in debian/maven.properties > - no encoding specified but have only ASCII source files > Setting a default encoding at the maven-debian-helper level will make no > difference. Lately I haven't discovered any issues in Maven, so the above might be true. Though I still don't understand why there is an ASCII fallback in Maven and maybe other Java tools. It appears to be completely anachronistic.
signature.asc
Description: OpenPGP digital signature