tag 864565 +patch
thanks

hi,

the chromium-shell binary is not supposed to be installed in /usr/bin
but rather /usr/lib/chromium. debian/chromium-shell.install pushes it
into /usr/bin at the moment.

The v8 natives file referred to is /usr/lib/chromium/natives_blob.bin,
other than that /usr/lib/chromium/snapshot_blob.bin is mandatory.

Moving the binary and running with strace shows:

open("/usr/lib/chromium/natives_blob.bin", O_RDONLY) = -1 ENOENT
open("/usr/lib/chromium/snapshot_blob.bin", O_RDONLY) = -1 ENOENT

Also the chromium package includes content_shell.pak which is not needed
for chromium itself and should be moved into the shell package itself.

open("/usr/lib/chromium/content_shell.pak", O_RDONLY) = -1 ENOENT

As the blobs are needed by both chromium and chromium-shell I'd suggest
to add a new chromium-blobs package and let chromium and chromium-shell
use Depends: chromium-blobs. That way we don't need to waste disk space
by installing chromium if only the shell is needed.


Further the chromium-shell binary wants to open a log within its path.

open("/usr/lib/chromium/content_shell.log", O_WRONLY|O_CREAT|O_APPEND, 0666) = 
-1

This will fail for unprivileged users but does not seem to be fatal.
I've got no idea if theres a build flag to move the logfile somewhere
else e.g. ~/.config/chromium.


build _and_ use-tested patch splitting the V8 blobs and fixing
chromium-shell attached.

bye
diff -Nrup a/debian/chromium-blobs.install b/debian/chromium-blobs.install
--- a/debian/chromium-blobs.install	1970-01-01 01:00:00.000000000 +0100
+++ b/debian/chromium-blobs.install	2017-07-08 00:25:15.117939830 +0200
@@ -0,0 +1 @@
+out/Release/*_blob.bin usr/lib/chromium
diff -Nrup a/debian/chromium.install b/debian/chromium.install
--- a/debian/chromium.install	2017-04-14 22:47:40.000000000 +0200
+++ b/debian/chromium.install	2017-07-08 00:25:15.117939830 +0200
@@ -1,8 +1,11 @@
 out/Release/chromium usr/lib/chromium
 out/Release/chrome-sandbox usr/lib/chromium
 
-out/Release/*.bin usr/lib/chromium
-out/Release/*.pak usr/lib/chromium
+out/Release/chrome_*.pak usr/lib/chromium
+out/Release/headless_*.pak usr/lib/chromium
+out/Release/mus_*.pak usr/lib/chromium
+out/Release/*resources.pak usr/lib/chromium
+out/Release/ui_*.pak
 
 out/Release/resources/en-US.pak usr/lib/chromium/locales
 
diff -Nrup a/debian/chromium-shell.install b/debian/chromium-shell.install
--- a/debian/chromium-shell.install	2017-01-02 03:14:00.000000000 +0100
+++ b/debian/chromium-shell.install	2017-07-08 00:25:15.117939830 +0200
@@ -1 +1,2 @@
-out/Release/chromium-shell usr/bin
+out/Release/chromium-shell usr/lib/chromium
+out/Release/content_shell.pak usr/lib/chromium
diff -Nrup a/debian/control b/debian/control
--- a/debian/control	2017-06-17 22:03:49.000000000 +0200
+++ b/debian/control	2017-07-08 00:25:15.118939830 +0200
@@ -87,12 +87,24 @@ Build-Depends:
  fonts-ipafont-mincho,
 Standards-Version: 3.9.8
 
+Package: chromium-blobs
+Architecture: i386 amd64 arm64 armhf
+Depends:
+ ${misc:Depends},
+ ${shlibs:Depends},
+Description: web browser - minimal shell
+ Web browser that aims to build a safer, faster, and more stable internet
+ browsing experience.
+ .
+ This package provides the V8 JavaScript engine natives/snapshot blobs.
+
 Package: chromium
 Architecture: i386 amd64 arm64 armhf
 Built-Using: ${Built-Using}
 Depends:
  ${misc:Depends},
  ${shlibs:Depends},
+ chromium-blobs (= ${binary:Version}),
  x11-utils,
  xdg-utils,
 Recommends:
@@ -135,6 +147,7 @@ Architecture: i386 amd64 arm64 armhf
 Depends:
  ${misc:Depends},
  ${shlibs:Depends},
+ chromium-blobs (= ${binary:Version}),
 Description: web browser - minimal shell
  Web browser that aims to build a safer, faster, and more stable internet
  browsing experience.
diff -Nrup a/debian/rules b/debian/rules
--- a/debian/rules	2017-06-17 22:03:49.000000000 +0200
+++ b/debian/rules	2017-07-08 00:49:11.628934350 +0200
@@ -118,6 +118,9 @@ override_dh_auto_install-arch:
 	    mkdir -p $$dst; \
 	    cp $$file $$dst/chromium.$$ext; \
 	    done
+	# create chromium-shell symlink
+	mkdir -p debian/chromium-shell/usr/bin
+	ln -sf ../lib/chromium/chromium-shell debian/chromium-shell/usr/bin
 
 override_dh_fixperms:
 	dh_fixperms --exclude chrome-sandbox

Attachment: signature.asc
Description: PGP signature

Reply via email to