On Sun, 9 Jul 2017, László Böszörményi wrote:
On Sun, Jul 9, 2017 at 4:32 PM, László Böszörményi (GCS) <g...@debian.org>
wrote:
On Sun, Jul 9, 2017 at 3:42 PM, Bob Friesenhahn
<bfrie...@simple.dallas.tx.us> wrote:
On Sun, 9 Jul 2017, László Böszörményi wrote:
As far as I am aware, I do not have any email from you about this. While
there was intermediate breakage, the png.c changes between Mercurial
changeset 15059:dea93a690fc1 and 15066:e8f859704230 are believed to solve
the assertion problem, as well as solve a memory leak problem in the error
path. The test suite is completely passing.
Learning from my previous email, when you noted that you are not the
author of the fix - I asked Glenn Randers-Pehrson as he is the author
of the fixing commits[1][2]. If I apply both on 1.3.26 then the self
test fails with:
Ah, just found out you have additional commits since then. Tested
check-in 4d0baa and it fixes the self test problem. But I suspect I
need dc7e12 as well, right?
You would need all of these changesets:
changeset: 15066:e8f859704230
user: Glenn Randers-Pehrson <glennrp+...@gmail.com>
date: Sat Jul 08 18:05:51 2017 -0400
files: coders/png.c
description:
Another attempt to checkin revised double-free fix.
changeset: 15064:4d0baa77245b
user: Bob Friesenhahn <bfrie...@graphicsmagick.org>
date: Sat Jul 08 12:59:45 2017 -0500
files: ChangeLog coders/png.c www/Changelog.html
description:
JNG: Fix double frees caused by changeset 15060:d445af60a8d5 commited
on 2017-07-06
changeset: 15060:d445af60a8d5
user: Glenn Randers-Pehrson <glennrp+...@gmail.com>
date: Thu Jul 06 10:42:50 2017 -0400
files: ChangeLog coders/png.c
description:
coders/png.c: Consolidate JNG cleanup into a new DestroyJNG()
function.
changeset: 15059:dea93a690fc1
parent: 15057:a42ae8447fe7
user: Glenn Randers-Pehrson <glennrp+...@gmail.com>
date: Wed Jul 05 09:41:22 2017 -0400
files: ChangeLog coders/png.c
description:
Stop crash due to zero-length color_image while reading a JNG
I think that this will result in a useful patch:
hg diff -r dea93a690fc1 -r e8f859704230 coders/png.c
Bob
--
Bob Friesenhahn
bfrie...@simple.dallas.tx.us, http://www.simplesystems.org/users/bfriesen/
GraphicsMagick Maintainer, http://www.GraphicsMagick.org/
