On Tue, Jul 25, 2017 at 10:04:02AM +0300, Alexander V. Lukyanov wrote:
> On Sat, Jul 22, 2017 at 10:52:19AM -0400, Thomas Dickey wrote:
> > c) add a cast to fix a signed/unsigned compiler warning
> 
> I will check if a newer/better version of regex.c if available in emacs (it 
> was taken from there).
> 
> > d) add (to help with running valgrind) the ExitProgram macro
> 
> Where is HAVE__NC_FREE_AND_EXIT defined?

It would be defined if you had (an optional) configure check for
_nc_free_and_exit.

I do this for example when debugging ncurses applications and want to check
for memory leaks.  But see

http://invisible-island.net/ncurses/ncurses.faq.html#config_leaks

> > e) fix a different fail-to-build with the opaque TERMTYPE
> 
> I don't see how these lines are equivalent:
> 
> -   TERMTYPE *tp = &cur_term->type;
> +   TERMTYPE *tp = (TERMTYPE *)(&cur_term);

They're the same because the first member of TERMINAL happens to be
a TERMTYPE, and since TERMINAL is opaque in current code (so you
cannot refer to the "type" member any longer).

-- 
Thomas E. Dickey <dic...@invisible-island.net>
http://invisible-island.net
ftp://invisible-island.net

Attachment: signature.asc
Description: Digital signature

Reply via email to