Christoph Biedl wrote:
> James Cameron wrote...
> > pptpsetup preserves mode on /etc/ppp/chap-secrets, but uses root
> > umask 0022 on /etc/ppp/peers/$TUNNEL, and group dip because of
> > setgid bit on /etc/ppp/peers.
> > 
> > My perl is rusty.  As far as I can see, it would be a call to chmod
> > after open, or a call to umask before open.  Latter seems easy, but
> > overrides user choice.
> ...
> > Patch attached, will be upstreamed after review.
> 
> That is almost the thing I was about to suggest, go for it.

Was pushed.  d33e18d.

> And, when convenient, please replace the two-argument form of open
> [...]

Was pushed.  c0dbacf.

-- 
James Cameron
http://quozl.netrek.org/

Reply via email to