retitle 872277 git: spurious "fatal: Out of memory, getdelim failed" forwarded 872277 https://public-inbox.org/git/20170809173928.h2ylvg5tp2p5i...@hopa.kiewit.dartmouth.edu/#r # bug introduced in v2.5.0-rc0~24^2~4 (strbuf_getwholeline: use getdelim # if it is available, 2015-04-16) found 872277 git/1:2.5.0-1 quit
Hi, Yaroslav Halchenko wrote: > Subject: patched version needed to avoid fatal: Out of memory, getdelim > failed crash You could say that about all bugs. A patched version is needed to fix the bug. :) [...] > For a while this issue was haunting us in various deployments, in particular > - on NFS mounts > - within standalone build of git-annex > that many git commands could crash randomly at various points with > > fatal: Out of memory, getdelim failed > > message. Recently upstream tracked it down, and offered a perspective patch > (see attached, cherry-picked from git upstream repository) -- it is a very > simple patch. I have tested it on our deployments (as applied against > 1:2.11.0-3 in stretch, but it is applicable to sid/experimental version as > well) > > original report upstream and the thread with further discussion(s) on > possible improvements to the patch: > https://public-inbox.org/git/20170809173928.h2ylvg5tp2p5i...@hopa.kiewit.dartmouth.edu/ > > Please please consider adapting this patch for the official packages of git in > Debian sid, and ideally to the version in stretch. This would be of great > help > to avoid those problems on the NFS-mounts and to generate fixed standalone > builds of git-annex (CCing git-annex author, Joey) which many users rely upon > on various (even non-Debian) systems. Thanks for writing. Can you say more about the impact? E.g. is there a reproduction recipe I can use to experience this on stable? How often do people experience this, and do they have a workaround? The patch also appeared to still be under discussion upstream. Someone investigating how the standard and various platforms handle errors from getdelim would likely be appreciated there. One possibility in the Debian packaging would be for us to pass HAVE_GETDELIM= in our build flags to avoid using getdelim altogether. That way, we get correct behavior while waiting for the upstream discussion to settle. Thanks, Jonathan
