On Wed, Aug 16, 2017 at 12:31:48PM +0200, Arturo Borrero Gonzalez wrote:
> What happens to '--disable-silent-rules'?

dh_auto_configure passes --disable-silent-rules unless DH_QUIET is set.

> Also, the nocheck thing should be a separated patch.
> Please, split the patches.

--- a/debian/rules
+++ b/debian/rules
@@ -7,14 +7,13 @@
 DPKG_EXPORT_BUILDFLAGS = 1
 include /usr/share/dpkg/buildflags.mk
 
-DEB_HOST_MULTIARCH ?= $(shell dpkg-architecture -qDEB_HOST_MULTIARCH)
 DEB_BUILD_ARCH_ENDIAN ?= $(shell dpkg-architecture -qDEB_BUILD_ARCH_ENDIAN)
 
 %:
        dh $@ --with autoreconf
 
 override_dh_auto_configure:
-       ./configure --prefix=/usr --libdir=/usr/lib/$(DEB_HOST_MULTIARCH) 
--with-json-parsing --disable-silent-rules
+       dh_auto_configure -- --with-json-parsing
 
 override_dh_strip:
        dh_strip --dbg-package=libnftnl4-dbg
--- a/debian/rules
+++ b/debian/rules
@@ -20,6 +20,7 @@
 override_dh_strip:
        dh_strip --dbg-package=libnftnl4-dbg
 
+ifeq ($(filter nocheck,$(DEB_BUILD_OPTIONS)),)
 override_dh_auto_test:
        dh_auto_test
 
@@ -26,3 +26,4 @@
 ifeq (little,$(DEB_BUILD_ARCH_ENDIAN))
        sh -c "cd tests; set -e; ./test-script.sh"
 endif
+endif

Helmut

Reply via email to