Bug#873047: libgfshare: gfsplit SIGSEGV if /dev/urandom is not accessible

[Chris Lamb]

Source: libgfshare
Version: 2.0.0-2
Severity: normal
Tags: patch

Hi,

gfsplit SIGSEGV if /dev/urandom is not accessible as it doesn't fallback
to the (correctly named!) gfshare_bad_idea_but_fill_rand_using_random; it
prints a warning to stderr.

Patch attached.


Best wishes,

-- 
      ,''`.
     : :'  :     Chris Lamb
     `. `'`      la...@debian.org / chris-lamb.co.uk
       `-

diff --git a/tools/gfsplit.c b/tools/gfsplit.c
index 9aadb22..c02c4d4 100644
--- a/tools/gfsplit.c
+++ b/tools/gfsplit.c
@@ -164,6 +164,7 @@ main( int argc, char **argv )
   if (access("/dev/urandom", R_OK) == 0) {
     gfshare_fill_rand = gfsplit_fill_rand;
   } else {
+    gfshare_fill_rand = gfshare_fill_rand = 
gfshare_bad_idea_but_fill_rand_using_random;
     fprintf(stderr, "\
 %s: Cannot access /dev/urandom, so using rand() instead (not secure!)\n\
 ", progname);