Hi,

On 24/08/17 08:59, Martin Quinson wrote:
> Hello,
> 
> thanks for the patch. I came to something very similar, only
> protecting it to be used only by GCC. I was waiting to find the time
> to test it before upload, but if you tested, I'll upload it right away.

I have tested the patch I attached on a mips machine. If you want I
could test your alternative patch as well.

Thanks,
James

> On Wed, Aug 23, 2017 at 02:41:15PM +0100, James Cowgill wrote:
>> Hi,
>>
>> The attached patch seems to work (ie replace atomic-library with it).
>> Using target_link_libraries should put any linker arguments at the end
>> instead of the beginning.
>>
>> Thanks,
>> James
> 
>> --- a/tools/cmake/MakeLib.cmake
>> +++ b/tools/cmake/MakeLib.cmake
>> @@ -114,6 +114,7 @@ if(enable_smpi AND APPLE)
>>    set(SIMGRID_DEP "${SIMGRID_DEP} -Wl,-U -Wl,_smpi_simulated_main")
>>  endif()
>>  
>> +set(SIMGRID_DEP "${SIMGRID_DEP} -Wl,--as-needed -latomic 
>> -Wl,--no-as-needed")
>>  target_link_libraries(simgrid       ${SIMGRID_DEP})
>>  
>>  # Dependencies from maintainer mode

Attachment: signature.asc
Description: OpenPGP digital signature

Reply via email to