On Sat, 26 Aug 2017 at 10:51 Jason Pleau <ja...@jpleau.ca> wrote: > Hi again. > > On 08/21/2017 06:41 AM, Alok Singh wrote: > > Package: i3blocks > > Version: 1.4-3+b1 > > Severity: normal > > > > Dear Maintainer, > > > > Not sure when this happened but the regexp in cpu_usage cannot parse the > > output of mpstat anymore. Patch attached. > > > > I investigated, and this is strange, I cannot reproduce your exact issue. >
My issue was exactly what is described in https://github.com/vivien/i3blocks/pull/252 After looking at mpstat, I figured the "Average" line was the one I'd like to be shown in the widget while the regexp as written would pick the first CPU. This is something that the github issue above is silent on. http://sources.debian.net/src/i3blocks/1.4-3/scripts/cpu_usage/#L34 Yes, this is indeed the version I had before I created the patch. I have inverted the original file and my patched file. So applying the patch would not change the file. I have attached the fixed patch below. My apologies for the mistake. > I will however add a patch that was recently added as a PR upstream (the > script does not work with newer kernel/mpstat): > https://github.com/vivien/i3blocks/pull/252 Thank you, that should fix the problem. There is a difference between what I have done and what upstream has done and I leave it to your judgement if you'd like to change the regexp to use the "Average" line. Ideally, upstream should accept this patch. Thanks muchly for maintaining this package which I am sure has a loyal if small following :) -- Alok
cpu_usage.patch
Description: Binary data
