Hi Andrey, On Tue, 29 Aug 2017 23:52:48 +0500 Andrey Rahmatullin <w...@debian.org> wrote: > On Thu, Aug 24, 2017 at 04:45:56PM -0300, Roberto Oliveira wrote: > > > I still see a lot of old junk in debian/control: > > > - did you write that Build-Depends? if no, please write them from scratch, > > > making sure they are complete and necessary. > > I Checked all the dependencies and now just the required dependencies are > > in control file. > dh-autoreconf is not needed and lintian tells that. Fixed.
> libtool and g++ are already pulled by build-essential and debhelper. Fixed. > g++ (>>3.3.1) is always true for many years. > Are you sure zlib1g-dev is needed? The packages don't depend on zlib. I thought it was but I did a second check and seems it isn't needed. Fixed. > > > Is libjvmti_oprofile intended to be a public shared library? It looks like > > > a plugin. > > Yes, it is a plugin, I moved it to the correct location. > If both libs are not public shared libs you shouldn't package them as if > they are. This includes .symbols, development files, the package names etc. Fixed. As both are Oprofile plugins and don't bring extra deps, I'm shipping them in Oprofile package. > Why do you create the user with --home /var/lib/oprofile --no-create-home? > Does it need the home dir or no? What is /var/lib/oprofile? Oprofile needs the 'oprofile' user and group to enable profiling JITed code but it doesn't need the home directory. I removed the --home option but Lintian complained about: maintainer-script-should-not-use-adduser-system-without-home and suggested: --no-create-home --home /nonexistent I applied Litian's suggestion but if it is not correct, I can change. > --with autoreconf is the default with debhelper 10. Fixed. > Why does oprofile depend on libopagent1? Fixed. I'm now shipping libopagent1 in Oprofile as it is a plugin. > -- > WBR, wRAR