On Fri, Sep 01, 2017 at 08:50:05PM +0200, Boud Roukema wrote: > On Fri, 1 Sep 2017, Adam Borowski wrote: > > Also, the vast majority of packages don't trigger this warning as they > > request LFS unconditionally instead of trying to autodetect it. > > The lintian warning here: > https://lintian.debian.org/tags/binary-file-built-without-LFS-support.html > says "This can be done by using the AC_SYS_LARGEFILE macro with autoconf, > or... " > > This is what I've done in mpgrafic, since (in principle) autoconf > makes things less hardwired. > > Isn't it cleaner to use the AC_SYS_LARGEFILE autoconf macro rather > than hardwire something such as -D_FILE_OFFSET_BITS=64 as a > non-optional compile option?
That assumes your project uses autotools -- they seem to have rapidly regressed recently, and projects are fleeing them left and right. And what AC_SYS_LARGEFILE does, at least on Linux, is to return a hardcoded setting so programs switch from off_t to off64_t whether they need to or not. This does the right thing on old 32-bit archs and is harmless on 64-bit and new 32-bit. The problem is in snowflake packages that do things their own way and enable LFS only when it's actually needed. Here's where the lintian false positive triggers. Meow! -- ⢀⣴⠾⠻⢶⣦⠀ ⣾⠁⢰⠒⠀⣿⡁ Vat kind uf sufficiently advanced technology iz dis!? ⢿⡄⠘⠷⠚⠋⠀ -- Genghis Ht'rok'din ⠈⠳⣄⠀⠀⠀⠀