Package: cloudprint-service
Version: 0.14-8
Severity: normal

Dear Maintainer,

Since cloudprintd requires a working network connection and DNS
resolver, the systemd service file should declare After (and probably
Wants) of network-online.service.  Although fa8d97e adds
network.service, this will be insufficient as it has little effect
during startup.  For a full explanation, see:

https://www.freedesktop.org/wiki/Software/systemd/NetworkTarget/#conceptsinsystemd
https://www.freedesktop.org/software/systemd/man/systemd.special.html#network-online.target
https://unix.stackexchange.com/q/126009

For reference, currently the service can be started before a network
connection is configured, resulting in errors such as the following:

Sep 16 09:48:05 servername cloudprintd[249]: Traceback (most recent call last):
Sep 16 09:48:05 servername cloudprintd[249]:   File "/usr/sbin/cloudprintd", 
line 11, in <module>
Sep 16 09:48:05 servername cloudprintd[249]:     
load_entry_point('cloudprint==0.14', 'console_scripts', 'cloudprint-cmd')()
Sep 16 09:48:05 servername cloudprintd[249]:   File 
"/usr/share/cloudprint/cloudprint/cloudprint.py", line 611, in main
Sep 16 09:48:05 servername cloudprintd[249]:     auth.load()
Sep 16 09:48:05 servername cloudprintd[249]:   File 
"/usr/share/cloudprint/cloudprint/cloudprint.py", line 187, in load
Sep 16 09:48:05 servername cloudprintd[249]:     self.refresh()
Sep 16 09:48:05 servername cloudprintd[249]:   File 
"/usr/share/cloudprint/cloudprint/cloudprint.py", line 169, in refresh
Sep 16 09:48:05 servername cloudprintd[249]:     'refresh_token': 
self.refresh_token,
Sep 16 09:48:05 servername cloudprintd[249]:   File 
"/usr/lib/python2.7/dist-packages/requests/api.py", line 110, in post
Sep 16 09:48:05 servername cloudprintd[249]:     return request('post', url, 
data=data, json=json, **kwargs)
Sep 16 09:48:05 servername cloudprintd[249]:   File 
"/usr/lib/python2.7/dist-packages/requests/api.py", line 56, in request
Sep 16 09:48:06 servername cloudprintd[249]:     return 
session.request(method=method, url=url, **kwargs)
Sep 16 09:48:06 servername cloudprintd[249]:   File 
"/usr/lib/python2.7/dist-packages/requests/sessions.py", line 488, in request
Sep 16 09:48:06 servername cloudprintd[249]:     resp = self.send(prep, 
**send_kwargs)
Sep 16 09:48:06 servername cloudprintd[249]:   File 
"/usr/lib/python2.7/dist-packages/requests/sessions.py", line 609, in send
Sep 16 09:48:06 servername cloudprintd[249]:     r = adapter.send(request, 
**kwargs)
Sep 16 09:48:06 servername cloudprintd[249]:   File 
"/usr/lib/python2.7/dist-packages/requests/adapters.py", line 487, in send
Sep 16 09:48:06 servername cloudprintd[249]:     raise ConnectionError(e, 
request=request)
Sep 16 09:48:06 servername cloudprintd[249]: 
requests.exceptions.ConnectionError: 
HTTPSConnectionPool(host='accounts.google.com', port=443): Max retries exceeded 
with url: /o/oauth2/token (Caused by 
NewConnectionError('<requests.packages.urllib3.connection.VerifiedHTTPSConnection
 object at 0xb56cf6b0>: Failed to establish a new connection: [Errno -3] 
Temporary failure in name resolution',))
Sep 16 09:48:07 servername systemd[1]: cloudprintd.service: Main process 
exited, code=exited, status=1/FAILURE
Sep 16 09:48:07 servername systemd[1]: cloudprintd.service: Unit entered failed 
state.
Sep 16 09:48:07 servername systemd[1]: cloudprintd.service: Failed with result 
'exit-code'.
Sep 16 10:19:52 servername systemd[1]: cloudprintd.service: Service hold-off 
time over, scheduling restart.

Thanks,
Kevin

-- System Information:
Debian Release: buster/sid
  APT prefers testing
  APT policy: (990, 'testing'), (500, 'unstable'), (101, 'experimental')
Architecture: amd64 (x86_64)
Foreign Architectures: i386

Kernel: Linux 4.13.0-kevinoid1 (SMP w/4 CPU cores)
Locale: LANG=en_US.utf8, LC_CTYPE=en_US.utf8 (charmap=UTF-8), 
LANGUAGE=en_US.utf8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash
Init: systemd (via /run/systemd/system)

Versions of packages cloudprint-service depends on:
ii  cloudprint           0.14-8
ii  init-system-helpers  1.49
ii  systemd              234-3

cloudprint-service recommends no packages.

cloudprint-service suggests no packages.

Reply via email to