Hi, Lukas, Thanks for the new round of reviews. You're making me learn a ton. :)
On 24 Sep 2017, Lukas Schwaighofer wrote: >On Sun, 24 Sep 2017 15:15:41 -0300 >"Gabriel F. T. Gomes" <gabr...@inconstante.eti.br> wrote: >> >> In that same message [1], you suggested the use of a version control >> system, but I don't know where to make it public (I know that alioth >> is being discontinued, so I'm a bit lost with this). > >I hope someone here will have a suggestion where your repository can >live. In the meantime, I can keep it in my personal server [1]. However, I don't think it's a good place for keeping it in the long run, because I do not fully trust myself as a sysadmin. Hehehe. [1] http://git.inconstante.eti.br/?p=pragha-debian.git;a=shortlog;h=refs/heads/unstable >* The upstream tarball you uploaded to mentors is not exactly the same > one as on github: > > $ cmp pragha-1.3.3.tar.gz pragha_1.3.3.orig.tar.gz > pragha-1.3.3.tar.gz pragha_1.3.3.orig.tar.gz differ: byte 5, line 1 Where did you get pragha-1.3.3.tar.gz from? I got it from https://github.com/pragha-music-player/pragha/archive/v1.3.3.tar.gz. The files are not exactly the same, as you mentioned, but their contents, after extraction, are identical. > If you use git and git-buildpackage, make sure to use the > "pristine-tar" feature. When using this, a small delta file will be > added to a special pristine-tar branch. This allows to reconstruct > the original tarball exactly as it was. I wasn't aware of git-buildpackage, so I was making the tarball by hand and building with debuild. Thanks for pointing this out. On the other hand, I still do not understand how git-buildpackage works. All my attempts to use it still resulted in a source tarball (.orig.tar.gz) that is not exactly the same as the tarball from upstream. >* In the debian/watch file you should replace "<project>" with > "pragha" (it also works as is, but then the downloaded tarball is > called "<project>-1.3.3.tar.gz" before the symlink is created). Done. >* in debian/patches/fix-appstream-errors.patch: > - referencing the ITP bug here does not make sense; you should only > use "Bug-Debian" if there is a bug in the Debian BTS that is > related to the patch (for example, if someone reported in the > Debian BTS that the appstream xml data is wrong) > - Instead here you should record the URL of your pull request: > > Bug: https://github.com/pragha-music-player/pragha/pull/125 Makes sense. Done. I uploaded a new package, which contains these changes and which was built with git-buildpackage. Best regards, Gabriel