On Tue, Oct 24, 2017 at 08:26:18AM -0400, Antoine Beaupré wrote:
> > err, how about a shorter test like the following one ?
> >
> > if (scalar grep { $_ } ( $opt_i, $opt_a, $opt_e, ...) < 1)
> >
> > HTH
>
> There are a bilion such patches to be done in dch. I'm just following
> the existing style...
Sure, but that "existing style" is just awful, and is the result of
"organic" growing of the code without anybody ever considering a real
refactor. I'm one of those that advocates changing the style slowly as
needed rather than waiting for some mystical time when somebody will
refactor it all. So, if you see one bit of code that you think it would
be better done another way, just change it :)
--
regards,
Mattia Rizzolo
GPG Key: 66AE 2B4A FCCF 3F52 DA18 4D18 4B04 3FCD B944 4540 .''`.
more about me: https://mapreri.org : :' :
Launchpad user: https://launchpad.net/~mapreri `. `'`
Debian QA page: https://qa.debian.org/developer.php?login=mattia `-
signature.asc
Description: PGP signature
