On Thu 2017-08-31 12:07:10 +1000, Jeremy Visser wrote:
> I've attached a patch which fixes the issue.

Jeremy's patch (below) looks reasonable to me.  Even better would be to
have it include other useful metadata in the [Unit] section, like:

Documentation=man:xscreensaver(1)
Documentation=man:xscreensaver-command(1)
Documentation=man:xscreensaver-demo(1)
PartOf=graphical-session.target

xscreensaver(1) currently has a suggestion for this file.  It should
probably also be adjusted to remove the example, and explain
specifically that all the user needs to do is:

   systemctl --user enable xscreensaver

Arguably, this user unit should be enabled by default.  Is there any
reason to ship it disabled?

    --dkg

> From 76072fa4cba00e6a6009324d6b9e0cf1d3fdc82f Mon Sep 17 00:00:00 2001
> From: Jeremy Visser <jeremyvis...@google.com>
> Date: Thu, 31 Aug 2017 11:53:00 +1000
> Subject: [PATCH] Fix broken systemd unit
>
> The ExecStart= line must be an absolute path as per systemd.service(5),
> but is currently a relative path. This change points it to
> /usr/bin/xscreensaver.
> ---
>  debian/xscreensaver.service | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/debian/xscreensaver.service b/debian/xscreensaver.service
> index 5e8f13d..c5298f2 100644
> --- a/debian/xscreensaver.service
> +++ b/debian/xscreensaver.service
> @@ -2,7 +2,7 @@
>  Description=XScreenSaver
>  
>  [Service]
> -ExecStart=xscreensaver
> +ExecStart=/usr/bin/xscreensaver
>  
>  [Install]
>  WantedBy=default.target
> -- 
> 2.14.1.581.gf28d330327-goog

Attachment: signature.asc
Description: PGP signature

Reply via email to