tags 862461 + patch
thanks

I agree with Nathaniel, the currently displayed message is too
confusing for regular users. A proper message should be displayed,
even if it means a (small!) deviation from upstream.

I am attaching a patch here, please consider!
Description: Report that root access is required
 When perf_event_paranoid level is set to 3 (default), tiptop requires
 root access to be run (#862461). Notify the user accordingly.
Author: Gunnar Wolf <gw...@debian.org>

Origin: vendor https://bugs.debian.org/862461
Bug-Debian: https://bugs.debian.org/862461
Forwarded: no
Reviewed-By: Gunnar Wolf <gw...@debian.org>
Last-Update: 2017-10-31

Index: tiptop-2.3.1/src/requisite.c
===================================================================
--- tiptop-2.3.1.orig/src/requisite.c
+++ tiptop-2.3.1/src/requisite.c
@@ -69,8 +69,11 @@ int check()
     else if (strcmp(os.release, "2.6.31") < 0) {  /* lexicographic order */
       fprintf(stderr, "Linux 2.6.31+ is required, OS reports '%s'.\n",
               os.release);
-    }
-    else {
+    } else if (paranoia_level == 3) {
+      fprintf(stderr, "Your kernel is set with an event paranoia value of 3\n");
+      fprintf(stderr, "Either run this program as root, or set a lower\n");
+      fprintf(stderr, "paranoia value at '%s'.\n", PARANOID2);
+    } else {
       fprintf(stderr, "Don't know why...\n");
     }
     exit(EXIT_FAILURE);

Attachment: signature.asc
Description: PGP signature

Reply via email to