Control: tags -1 + pending
Control: tags 794138 + pending
Control: tags 869350 + pending

Hi,

2016-02-28 16:28 Helmut Grohne:
Control: tags -1 + patch

Hi Samuel,

On Sun, Feb 28, 2016 at 03:04:23PM +0100, Samuel Thibault wrote:
startpar can be fixed to cross-build fine, please see attached patch
which defines CC as appropriate.

Your patch has two little problems.
* It relies on building under dpkg-buildpackage. Policy still allows
  building by invoking ./debian/rules directly and then
  DEB_HOST_GNU_TYPE may be unset.
* Your patch unconditionally overwrites CC and thus breaks e.g.
  CC=clang dpkg-buildpackage. Note that since CC has a built-in
  default, CC ?= ... cannot be used.

I am attaching an updated version that addresses both issues.

Thanks both, I am NMUing the package with these changes.


Cheers.
--
Manuel A. Fernandez Montecelo <manuel.montez...@gmail.com>

Reply via email to