Control: tags -1 + patch

On Mon, 27 Nov 2017 23:43:34 +0200 Adrian Bunk <b...@debian.org> wrote:
> Source: ufo-filters
> Version: 0.14.1+dfsg1-1
> Severity: serious
> 
> cd /build/1st/ufo-filters-0.14.1+dfsg1/obj-x86_64-linux-gnu/src && 
> /usr/bin/cc -DG_LOG_DOMAIN=\"Ufo\" -D_FILE_OFFSET_BITS=64 -D_LARGE_FILES 
> -Dufofilterread_EXPORTS -I/build/1st/ufo-filters-0.14.1+dfsg1/deps/oclfft 
> -I/usr/include/x86_64-linux-gnu -I/usr/include/hdf5/serial 
> -I/build/1st/ufo-filters-0.14.1+dfsg1/obj-x86_64-linux-gnu/src 
> -I/build/1st/ufo-filters-0.14.1+dfsg1/src -I/usr/include/ufo-0 
> -I/usr/include/json-glib-1.0 -I/usr/include/glib-2.0 
> -I/usr/lib/x86_64-linux-gnu/glib-2.0/include  -g -O2 -fstack-protector-strong 
> -Wformat -Werror=format-security -Wdate-time -D_FORTIFY_SOURCE=2 -std=c99 
> -std=c99 -pedantic -Wall -Wextra -fPIC -Wno-unused-parameter 
> -Wno-deprecated-declarations -fopenmp -fPIC   -Wall -Wextra -fPIC 
> -Wno-unused-parameter -o CMakeFiles/ufofilterread.dir/ufo-read-task.c.o   -c 
> /build/1st/ufo-filters-0.14.1+dfsg1/src/ufo-read-task.c
> ...
> /build/1st/ufo-filters-0.14.1+dfsg1/src/ufo-read-task.c: In function 
> 'read_filenames':
> /build/1st/ufo-filters-0.14.1+dfsg1/src/ufo-read-task.c:159:32: error: 
> 'GLOB_TILDE' undeclared (first use in this function); did you mean 
> 'G_IS_FILE'?
>      glob (pattern, GLOB_MARK | GLOB_TILDE, NULL, &filenames);
>                                 ^~~~~~~~~~
>                                 G_IS_FILE
> /build/1st/ufo-filters-0.14.1+dfsg1/src/ufo-read-task.c:159:32: note: each 
> undeclared identifier is reported only once for each function it appears in
> cd /build/1st/ufo-filters-0.14.1+dfsg1/obj-x86_64-linux-gnu/src && 
> /usr/bin/cmake -E cmake_link_script 
> CMakeFiles/ufofiltervolumerender.dir/link.txt --verbose=1
> cd /build/1st/ufo-filters-0.14.1+dfsg1/obj-x86_64-linux-gnu/src && 
> /usr/bin/cmake -E cmake_link_script 
> CMakeFiles/ufofiltermedianfilter.dir/link.txt --verbose=1
> make[3]: Leaving directory 
> '/build/1st/ufo-filters-0.14.1+dfsg1/obj-x86_64-linux-gnu'
> src/CMakeFiles/ufofilterread.dir/build.make:65: recipe for target 
> 'src/CMakeFiles/ufofilterread.dir/ufo-read-task.c.o' failed
> make[3]: *** [src/CMakeFiles/ufofilterread.dir/ufo-read-task.c.o] Error 1
> 
> 
> GLOB_TILDE is a GNU extension, therefore it looks correct
> that it is (no longer) available with -std=c99.

Patch proposal attached.

_g.
diff -Nru ufo-filters-0.14.1+dfsg1/debian/changelog 
ufo-filters-0.14.1+dfsg1/debian/changelog
--- ufo-filters-0.14.1+dfsg1/debian/changelog   2017-10-13 18:39:58.000000000 
+0200
+++ ufo-filters-0.14.1+dfsg1/debian/changelog   2017-11-28 21:48:35.000000000 
+0100
@@ -1,3 +1,12 @@
+ufo-filters (0.14.1+dfsg1-1.1) UNRELEASED; urgency=medium
+
+  * Non-maintainer upload.
+  * New patch glob_tilde.patch: force GNU extensions in
+    src/ufo-read-task.c to have GLOB_TILDE while building with -std=c99
+    (closes: #882955)
+
+ -- Gilles Filippini <p...@debian.org>  Tue, 28 Nov 2017 21:48:35 +0100
+
 ufo-filters (0.14.1+dfsg1-1) unstable; urgency=medium
 
   * New upstream release.
diff -Nru ufo-filters-0.14.1+dfsg1/debian/patches/glob_tilde.patch 
ufo-filters-0.14.1+dfsg1/debian/patches/glob_tilde.patch
--- ufo-filters-0.14.1+dfsg1/debian/patches/glob_tilde.patch    1970-01-01 
01:00:00.000000000 +0100
+++ ufo-filters-0.14.1+dfsg1/debian/patches/glob_tilde.patch    2017-11-28 
21:48:31.000000000 +0100
@@ -0,0 +1,13 @@
+Index: ufo-filters/src/ufo-read-task.c
+===================================================================
+--- ufo-filters.orig/src/ufo-read-task.c
++++ ufo-filters/src/ufo-read-task.c
+@@ -17,6 +17,8 @@
+  * License along with this library.  If not, see 
<http://www.gnu.org/licenses/>.
+  */
+ 
++#define _GNU_SOURCE
++
+ #include <gmodule.h>
+ #include <stdlib.h>
+ #include <string.h>
diff -Nru ufo-filters-0.14.1+dfsg1/debian/patches/series 
ufo-filters-0.14.1+dfsg1/debian/patches/series
--- ufo-filters-0.14.1+dfsg1/debian/patches/series      2017-10-13 
18:38:42.000000000 +0200
+++ ufo-filters-0.14.1+dfsg1/debian/patches/series      2017-11-28 
21:48:35.000000000 +0100
@@ -1 +1,2 @@
 patch-conf.py-in-order-to-use-the-locall
+glob_tilde.patch

Attachment: signature.asc
Description: OpenPGP digital signature

Reply via email to