control: tags -1 -patch
Hi Carlos,
thanks for having a look!
On Wed, Dec 20, 2017 at 09:56:20PM +1100, Carlos Maddela wrote:
> diff --git a/gbp/scripts/common/pq.py b/gbp/scripts/common/pq.py
> index 004c231..d092565 100644
> --- a/gbp/scripts/common/pq.py
> +++ b/gbp/scripts/common/pq.py
> @@ -177,7 +177,7 @@ def write_patch_file(filename, commit_info, diff):
> msg.set_payload(body.encode('us-ascii'))
> except (UnicodeEncodeError):
> msg.set_payload(body, charset)
> - patch.write(msg.as_string(unixfrom=False,
> maxheaderlen=77).encode('utf-8'))
> + patch.write(msg.as_bytes(unixfrom=False))
Good catch but we need to keep breaking headers at that value to not
introduce further diff noise. Looking at the docs max_line_length is
there as well which could work.
Cheers,
-- Guido
