Marc Haber wrote:
> On Mon, Dec 25, 2017 at 10:02:48PM +0000, Ben Hutchings wrote:
>> Given that commit fb1522e099f0 was merged after -rc7 I assume it's an
>> important fix, though the commit message doesn't spell that out. So I
>> think that whenever bisect asks you to test a version that doesn't
>> contain it, you should cherry-pick it first to avoid the other bug. (I
>> think you will then need to use 'git bisect good|bad HEAD^' after
>> testing, rather than implicitly flagging the current head commit.)
>
> Would
> git show fb1522e099f0 | patch -p1
> build/test
> git reset --hard
> git bisect good|bad
> be the same thing? I would feel much more comfortable with that.
Yes. (The main advantage of 'git cherry-pick' over that is that it
performs rename detection, but that shouldn't be relevant here. You
can similarly do
git cherry-pick --no-commit fb1522e099f0
build/test
git reset --hard
git bisect good|bad
)
Thanks,
Jonathan
