On 2018-01-02 02:02, Andreas Henriksson wrote:
Hej Henrik, Vincent,
On Tue, Jan 02, 2018 at 12:11:16AM +0100, Henrik Sandklef wrote:
I have removed deps to gnomeui (gconf had already been removed) from Xnee
sources.
Vincent, please see the attached debdiff that incorporates Henriks
change as a patch in debian/patches/ for your convenience.
(You might also want to look into upgrading to a non-deprecated
debhelper compat level (apparently 5 is currently used while anything
before 9 is deprecated), etc. See also other lintian warnings.)
Can I assist you in any way?
Thanks for the offer! From my point of view it's really up to Vincent
how he wants to handle this - I just wanted to remind and point out
the urgency of this issue being resolved in any way.
Hopefully Vincent will get in touch with you if he has something
to discuss.
While poking around I noticed a couple of things which I'm just
mentioning in case it'll interest you:
- Is it true CVS is still used? (Or else I've probably looked at the
wrong upstream location)
Yes. I do not have time to maintain Xnee as I should. Switching VCS is
not prio #1.
- I guess $(libgnomeui_LIBS) and $(libgnomeui_CFLAGS) can now also
be dropped from gnee/src/Makefile.am (and possibly other places?)
Thanks a lot.
- Apparently configure(.in) has no check for pkg-config modules actually
exiting (which I ran into while having pkg-config itself, but not
gtk+-2.0.pc since the libgtk2.0-dev build-dependency was missing in
the debian xnee package). A more obvious error message could have
been produced by explicitly checking
if ! $PKGCONF --exists $GTK2_MODULE >= GTK2_VERSION and erroring out.
Even better though... (see below).
- directly invoking pkg-config is not cross compilation safe (as lintian
points out). It would probably be better to replace all pkg-config
usage with PKG_CHECK_MODULES macro usage instead. (And gtk-config is
long gone so you can probably retire that code path while at it.)
This should also give a more modern and fool-proof configure process.
See if I can squeeze these in.
The lintian report might also give you useful information:
https://lintian.debian.org/maintainer/ber...@debian.org.html#xnee_3.19-1
Med vänlig hälsning,
Andreas Henriksson
Tusen tack och gott nytt år
/henrik
