Control: reopen -1
Control: affects 882785 + src:geeqie
On Wed, Jan 03, 2018 at 11:21:06PM +0000, Debian Bug Tracking System wrote:
> * New upstream version 1.4
> - Really fixes the problems with trapping errors (Closes: 883526)
I'm very sorry to reopen this bug again, but this fix doesn't quite cut
it. I goes a long way, but is still incomplete.
This is how it looks like when gdk-pixbuf-csource[1] fails to run now:
| dh_auto_build -a -O--parallel -O--fail-missing
| make -j1
| make[1]: Entering directory '/<<PKGBUILDDIR>>'
| make all-recursive
| make[2]: Entering directory '/<<PKGBUILDDIR>>'
| Making all in src
| make[3]: Entering directory '/<<PKGBUILDDIR>>/src'
| Making all in icons
| make[4]: Entering directory '/<<PKGBUILDDIR>>/src/icons'
| Making all in svg
| make[5]: Entering directory '/<<PKGBUILDDIR>>/src/icons/svg'
| make[5]: Nothing to be done for 'all'.
| make[5]: Leaving directory '/<<PKGBUILDDIR>>/src/icons/svg'
| make[5]: Entering directory '/<<PKGBUILDDIR>>/src/icons'
| sh: 1: /usr/bin/gdk-pixbuf-csource: Exec format error
| !!! Failed to generate icons_inline.h !!!
| make[5]: Leaving directory '/<<PKGBUILDDIR>>/src/icons'
| make[4]: Leaving directory '/<<PKGBUILDDIR>>/src/icons'
| make[4]: Entering directory '/<<PKGBUILDDIR>>/src'
| powerpc64le-linux-gnu-gcc -DHAVE_CONFIG_H -I. -I.. -Wdate-time
-D_FORTIFY_SOURCE=2 -pthread -I/usr/include/glib-2.0
-I/usr/lib/powerpc64le-linux-gnu/glib-2.0/include -pthread
-I/usr/include/gtk-2.0 -I/usr/lib/powerpc64le-linux-gnu/gtk-2.0/include
-I/usr/include/gio-unix-2.0/ -I/usr/include/cairo -I/usr/include/pango-1.0
-I/usr/include/atk-1.0 -I/usr/include/cairo -I/usr/include/pixman-1
-I/usr/include/gdk-pixbuf-2.0 -I/usr/include/libpng16 -I/usr/include/pango-1.0
-I/usr/include/harfbuzz -I/usr/include/pango-1.0 -I/usr/include/glib-2.0
-I/usr/lib/powerpc64le-linux-gnu/glib-2.0/include -I/usr/include/freetype2
-I/usr/include/libpng16 -I/usr/include/lua5.1 -I.. -I.. -g -O2
-fdebug-prefix-map=/<<PKGBUILDDIR>>=. -fstack-protector-strong -Wformat
-Werror=format-security -Werror -Wno-error=deprecated-declarations
-Wno-error=sign-compare -Wno-error=return-type -c -o ui_bookmark.o ui_bookmark.c
| powerpc64le-linux-gnu-gcc -DHAVE_CONFIG_H -I. -I.. -Wdate-time
-D_FORTIFY_SOURCE=2 -pthread -I/usr/include/glib-2.0
-I/usr/lib/powerpc64le-linux-gnu/glib-2.0/include -pthread
-I/usr/include/gtk-2.0 -I/usr/lib/powerpc64le-linux-gnu/gtk-2.0/include
-I/usr/include/gio-unix-2.0/ -I/usr/include/cairo -I/usr/include/pango-1.0
-I/usr/include/atk-1.0 -I/usr/include/cairo -I/usr/include/pixman-1
-I/usr/include/gdk-pixbuf-2.0 -I/usr/include/libpng16 -I/usr/include/pango-1.0
-I/usr/include/harfbuzz -I/usr/include/pango-1.0 -I/usr/include/glib-2.0
-I/usr/lib/powerpc64le-linux-gnu/glib-2.0/include -I/usr/include/freetype2
-I/usr/include/libpng16 -I/usr/include/lua5.1 -I.. -I.. -g -O2
-fdebug-prefix-map=/<<PKGBUILDDIR>>=. -fstack-protector-strong -Wformat
-Werror=format-security -Werror -Wno-error=deprecated-declarations
-Wno-error=sign-compare -Wno-error=return-type -c -o ui_fileops.o ui_fileops.c
| powerpc64le-linux-gnu-gcc -DHAVE_CONFIG_H -I. -I.. -Wdate-time
-D_FORTIFY_SOURCE=2 -pthread -I/usr/include/glib-2.0
-I/usr/lib/powerpc64le-linux-gnu/glib-2.0/include -pthread
-I/usr/include/gtk-2.0 -I/usr/lib/powerpc64le-linux-gnu/gtk-2.0/include
-I/usr/include/gio-unix-2.0/ -I/usr/include/cairo -I/usr/include/pango-1.0
-I/usr/include/atk-1.0 -I/usr/include/cairo -I/usr/include/pixman-1
-I/usr/include/gdk-pixbuf-2.0 -I/usr/include/libpng16 -I/usr/include/pango-1.0
-I/usr/include/harfbuzz -I/usr/include/pango-1.0 -I/usr/include/glib-2.0
-I/usr/lib/powerpc64le-linux-gnu/glib-2.0/include -I/usr/include/freetype2
-I/usr/include/libpng16 -I/usr/include/lua5.1 -I.. -I.. -g -O2
-fdebug-prefix-map=/<<PKGBUILDDIR>>=. -fstack-protector-strong -Wformat
-Werror=format-security -Werror -Wno-error=deprecated-declarations
-Wno-error=sign-compare -Wno-error=return-type -c -o ui_help.o ui_help.c
| powerpc64le-linux-gnu-gcc -DHAVE_CONFIG_H -I. -I.. -Wdate-time
-D_FORTIFY_SOURCE=2 -pthread -I/usr/include/glib-2.0
-I/usr/lib/powerpc64le-linux-gnu/glib-2.0/include -pthread
-I/usr/include/gtk-2.0 -I/usr/lib/powerpc64le-linux-gnu/gtk-2.0/include
-I/usr/include/gio-unix-2.0/ -I/usr/include/cairo -I/usr/include/pango-1.0
-I/usr/include/atk-1.0 -I/usr/include/cairo -I/usr/include/pixman-1
-I/usr/include/gdk-pixbuf-2.0 -I/usr/include/libpng16 -I/usr/include/pango-1.0
-I/usr/include/harfbuzz -I/usr/include/pango-1.0 -I/usr/include/glib-2.0
-I/usr/lib/powerpc64le-linux-gnu/glib-2.0/include -I/usr/include/freetype2
-I/usr/include/libpng16 -I/usr/include/lua5.1 -I.. -I.. -g -O2
-fdebug-prefix-map=/<<PKGBUILDDIR>>=. -fstack-protector-strong -Wformat
-Werror=format-security -Werror -Wno-error=deprecated-declarations
-Wno-error=sign-compare -Wno-error=return-type -c -o ui_menu.o ui_menu.c
| powerpc64le-linux-gnu-gcc -DHAVE_CONFIG_H -I. -I.. -Wdate-time
-D_FORTIFY_SOURCE=2 -pthread -I/usr/include/glib-2.0
-I/usr/lib/powerpc64le-linux-gnu/glib-2.0/include -pthread
-I/usr/include/gtk-2.0 -I/usr/lib/powerpc64le-linux-gnu/gtk-2.0/include
-I/usr/include/gio-unix-2.0/ -I/usr/include/cairo -I/usr/include/pango-1.0
-I/usr/include/atk-1.0 -I/usr/include/cairo -I/usr/include/pixman-1
-I/usr/include/gdk-pixbuf-2.0 -I/usr/include/libpng16 -I/usr/include/pango-1.0
-I/usr/include/harfbuzz -I/usr/include/pango-1.0 -I/usr/include/glib-2.0
-I/usr/lib/powerpc64le-linux-gnu/glib-2.0/include -I/usr/include/freetype2
-I/usr/include/libpng16 -I/usr/include/lua5.1 -I.. -I.. -g -O2
-fdebug-prefix-map=/<<PKGBUILDDIR>>=. -fstack-protector-strong -Wformat
-Werror=format-security -Werror -Wno-error=deprecated-declarations
-Wno-error=sign-compare -Wno-error=return-type -c -o ui_misc.o ui_misc.c
| powerpc64le-linux-gnu-gcc -DHAVE_CONFIG_H -I. -I.. -Wdate-time
-D_FORTIFY_SOURCE=2 -pthread -I/usr/include/glib-2.0
-I/usr/lib/powerpc64le-linux-gnu/glib-2.0/include -pthread
-I/usr/include/gtk-2.0 -I/usr/lib/powerpc64le-linux-gnu/gtk-2.0/include
-I/usr/include/gio-unix-2.0/ -I/usr/include/cairo -I/usr/include/pango-1.0
-I/usr/include/atk-1.0 -I/usr/include/cairo -I/usr/include/pixman-1
-I/usr/include/gdk-pixbuf-2.0 -I/usr/include/libpng16 -I/usr/include/pango-1.0
-I/usr/include/harfbuzz -I/usr/include/pango-1.0 -I/usr/include/glib-2.0
-I/usr/lib/powerpc64le-linux-gnu/glib-2.0/include -I/usr/include/freetype2
-I/usr/include/libpng16 -I/usr/include/lua5.1 -I.. -I.. -g -O2
-fdebug-prefix-map=/<<PKGBUILDDIR>>=. -fstack-protector-strong -Wformat
-Werror=format-security -Werror -Wno-error=deprecated-declarations
-Wno-error=sign-compare -Wno-error=return-type -c -o ui_pathsel.o ui_pathsel.c
| sh: 1: /usr/bin/gdk-pixbuf-csource: Exec format error
| !!! Failed to generate ui_icons.h !!!
| powerpc64le-linux-gnu-gcc -DHAVE_CONFIG_H -I. -I.. -Wdate-time
-D_FORTIFY_SOURCE=2 -pthread -I/usr/include/glib-2.0
-I/usr/lib/powerpc64le-linux-gnu/glib-2.0/include -pthread
-I/usr/include/gtk-2.0 -I/usr/lib/powerpc64le-linux-gnu/gtk-2.0/include
-I/usr/include/gio-unix-2.0/ -I/usr/include/cairo -I/usr/include/pango-1.0
-I/usr/include/atk-1.0 -I/usr/include/cairo -I/usr/include/pixman-1
-I/usr/include/gdk-pixbuf-2.0 -I/usr/include/libpng16 -I/usr/include/pango-1.0
-I/usr/include/harfbuzz -I/usr/include/pango-1.0 -I/usr/include/glib-2.0
-I/usr/lib/powerpc64le-linux-gnu/glib-2.0/include -I/usr/include/freetype2
-I/usr/include/libpng16 -I/usr/include/lua5.1 -I.. -I.. -g -O2
-fdebug-prefix-map=/<<PKGBUILDDIR>>=. -fstack-protector-strong -Wformat
-Werror=format-security -Werror -Wno-error=deprecated-declarations
-Wno-error=sign-compare -Wno-error=return-type -c -o ui_spinner.o ui_spinner.c
| In file included from ui_spinner.c:36:0:
| ui_icons.h:3:0: error: unterminated #ifndef
| #ifndef UI_ICONS_H
|
| ui_spinner.c: In function 'spinner_new':
| ui_spinner.c:160:3: warning: 'gdk_pixbuf_new_from_inline' is deprecated
[-Wdeprecated-declarations]
| pb = gdk_pixbuf_new_from_inline(-1, icon_spinner, FALSE, NULL);
| ^~
| In file included from
/usr/include/gdk-pixbuf-2.0/gdk-pixbuf/gdk-pixbuf.h:34:0,
| from /usr/include/gtk-2.0/gdk/gdkpixbuf.h:37,
| from /usr/include/gtk-2.0/gdk/gdkcairo.h:28,
| from /usr/include/gtk-2.0/gdk/gdk.h:33,
| from /usr/include/gtk-2.0/gtk/gtk.h:32,
| from ui_spinner.c:31:
| /usr/include/gdk-pixbuf-2.0/gdk-pixbuf/gdk-pixbuf-core.h:362:12: note:
declared here
| GdkPixbuf* gdk_pixbuf_new_from_inline (gint data_length,
| ^~~~~~~~~~~~~~~~~~~~~~~~~~
| Makefile:971: recipe for target 'ui_spinner.o' failed
| make[4]: *** [ui_spinner.o] Error 1
| make[4]: Leaving directory '/<<PKGBUILDDIR>>/src'
| Makefile:1004: recipe for target 'all-recursive' failed
| make[3]: *** [all-recursive] Error 1
| make[3]: Leaving directory '/<<PKGBUILDDIR>>/src'
| Makefile:672: recipe for target 'all-recursive' failed
| make[2]: *** [all-recursive] Error 1
| make[2]: Leaving directory '/<<PKGBUILDDIR>>'
| Makefile:504: recipe for target 'all' failed
| make[1]: *** [all] Error 2
| make[1]: Leaving directory '/<<PKGBUILDDIR>>'
| dh_auto_build: make -j1 returned exit code 2
| debian/rules:4: recipe for target 'build-arch' failed
| make: *** [build-arch] Error 2
| dpkg-buildpackage: error: debian/rules build-arch subprocess returned exit
status 2
You observe that in contrast to earlier versions, we can now see the
intended "!!! Failed to generate ... !!!". Yet that echo command is
successful and from a make-pov, the whole invocation is. Thus make
continues (this build log is non-parallel). The final failure only comes
when the required symbols are not found.
I guess that replacing the "|| echo $message" with "|| { echo $message;
exit 1; }" fixes this, but I am no longer foolish enough to claim that
such a simple solution would just make it work as my judgement has been
wrong before.
Thank you for bearing with me on this difficult issue.
Helmut
[1] Do note that this failure is not a bug in geeqie. It's tracked
separately in #882785.
