On 2018-01-16 20:35:25, Harlan Lieberman-Berg wrote:
> tag 880246 +pending
> thanks
>
> Hi Antoine,
>
> I talked with the Privacy Tools team, and they've taken the patch.
> 0.10.3-1 now builds successfully and works fine! It's waiting for
> your upload.
Awesome, thanks!
I've reviewed your work, and it looks generally good.
However, I noticed you added a new patch to remove the `ipaddress`
dependency. That's fine: we want the thing to build. However, I think we
should strive to avoid debian-specific patches in general, unless
absolutely necessary.
In this case, I think we should find a way to make the `ipaddress`
dependency only apply on Python 2 installs. I think there's a way to
specify dependencies like this. Someone submitted a py3 patch to another
project i'm maintaining, but i can't find it right now... :(
Could you look into this to improve the patch and send it upstream? I
don't think it's a blocker for this upload, but I'd like to see this
fixed in the long term.
I made minor changes to the package (added more docs and moved to salsa)
and changed the changelog to make the upload my own (keeping credits).
I note that your email address was incorrect in the changelog, but that
was fixed by rewriting it. Next time, something to keep an eye on.
I uploaded the package to unstable and both alioth and salsa. That
should be the last upload to alioth, where i archived the repository by
setting a pre-receive hook to error and put a warning in the description
as well.
a.
--
Software gets slower faster than hardware gets faster.
- Wirth's law
