Bug#888583: ltsp: ltsp-client-builder should use console-setup-udeb instead of kbd-chooser

[Wolfgang Schweer]

Source: ltsp
Version: 5.5.10
Severity: important
User: debian-...@lists.debian.org
Usertags: debian-edu

Hi,

while testing Debian Edu Buster I noticed an installation failure at d-i menu
item 'Build LTSP chroot'. 

To tell it apart from Debian Edu specifics, I tried to install a plain 
buster system (desktop deselected to speed up things) with LTSP using

https://d-i.debian.org/daily-images/amd64/daily/netboot/mini.iso

and these added kernel params:

priority=low modules=ltsp-client-builder ltsp-client-builder/use_cdrom=false 
ltsp-client-builder/build-client-opts="--http-proxy=http://10.0.0.1:3142";

Installation fails with these log messages.

Jan 27 09:08:31 kbd-chooser[10482]: DEBUG: Mounting usbfs to look for kbd
Jan 27 09:08:31 kbd-chooser[10482]: DEBUG: Mounting debugfs to look for kbd
Jan 27 09:08:31 kbd-chooser[10482]: DEBUG: Parsing usb/devices file
Jan 27 09:08:31 kbd-chooser[10482]: DEBUG: Adding generic entry for AT keymaps
Jan 27 09:08:31 kbd-chooser[10482]: INFO: keyboard type at: present: true:  
Jan 27 09:08:31 kbd-chooser[10482]: INFO: keyboard type at: present: unknown  
Jan 27 09:08:31 kbd-chooser[10482]: INFO: Setting 
debian-installer/serial-console to false
Jan 27 09:08:31 kbd-chooser[10482]: INFO: Setting debian-installer/uml-console 
to false
Jan 27 09:08:31 kbd-chooser[10482]: INFO: kbd-chooser: arch at selected
Jan 27 09:08:31 kbd-chooser[10482]: INFO: choose_keymap: keymap = no keymap
Jan 27 09:08:31 kbd-chooser[10482]: INFO: kbd_chooser: setting keymap no keymap
Jan 27 09:08:31 kbd-chooser[10482]: ERROR **: kbd-chooser: cannot open file no 
keymap
Jan 27 09:08:31 main-menu[178]: WARNING **: Configuring 'kbd-chooser' failed 
with error code 1
Jan 27 09:08:31 main-menu[178]: WARNING **: Menu item 'ltsp-client-builder' 
failed.

This happens, if the default answer to the kbd-chooser prompt is 
selected (at keyboard, due to console-setup-udeb earlier). 

Selecting the non-default second one (something like 'keep kernel 
keymap) lets the installation go on.

Also, running 'rm /var/lib/dpkg/info/kbd-chooser.*' inside d-i 
environment and thus dropping kbd-chooser completely is working.

IIRC, kbd-chooser has been deprecated inside d-i; I figure something 
like this would fix it:

diff --git a/debian/control b/debian/control
index 690d6f4f..228be1ff 100644
--- a/debian/control
+++ b/debian/control
@@ -208,7 +208,7 @@ Depends: ${misc:Depends},
   ${shlibs:Depends},
   ${vendor:Depends},
   pkgsel
-X-Debian-Depends: kbd-chooser
+X-Debian-Depends: console-setup-udeb
 X-Ubuntu-Depends: console-setup-udeb
 XB-Installer-Menu-Item: 7000
 Description: build an LTSP environment in the installer target

Above patch attached as well, please check.

Wolfgang

diff --git a/server/ltsp-config b/server/ltsp-config
index c7fa7c4f..fb6f51a0 100755
--- a/server/ltsp-config
+++ b/server/ltsp-config
@@ -211,9 +211,12 @@ EOF
                 echo "Removing old configuration file $conf in order to upgrade it"
                 rm -f "$conf"
             fi
+        echo "Adjusting old configuration file $conf to be compatible with NBD"
+        sed -i "s#/opt/ltsp#opt/ltsp#" /etc/nbd-server/conf.d/ltsp_$name.conf
         fi
 
         if check_overwrite $conf; then
+            BASE=$(echo $BASE | sed -e "s#/##")
             cat >"$conf" <<EOF
 [$BASE/$name]
 exportname = $image

signature.asc
Description: PGP signature