Source: cloudkitty
Version: 6.0.0-1
Severity: wishlist
Tags: patch
User: reproducible-bui...@lists.alioth.debian.org
Usertags: hostname buildpath
X-Debbugs-Cc: reproducible-b...@lists.alioth.debian.org

Hi,

Whilst working on the Reproducible Builds effort [0], we noticed
that cloudkitty could not be built reproducibly:

 * Embeds the current hostname via socket.getfqdn()

 * Installs .doctree files. These are usually deleted by dh_sphinxdoc 
   but if the documentation building fails (as it does, with "|| true" 
   deliberately appended), we need to delete the target directory.

  This will probably lead to a "empty binary package" warning, but it
  was essentially empty anyway.

Patch attached.

 [0] https://reproducible-builds.org/


Regards,

-- 
      ,''`.
     : :'  :     Chris Lamb
     `. `'`      la...@debian.org / chris-lamb.co.uk
       `-
--- a/debian/rules      2018-02-02 21:13:26.001560342 +0000
--- b/debian/rules      2018-02-02 22:41:35.114231445 +0000
@@ -33,7 +33,7 @@
 override_dh_sphinxdoc:
 ifeq (,$(findstring nodocs, $(DEB_BUILD_OPTIONS)))
        # Warning: building doc fails.
-       sphinx-build $(SPHINXOPTS) -b html doc/source 
$(CURDIR)/debian/cloudkitty-doc/usr/share/doc/cloudkitty-doc/html || true
+       sphinx-build $(SPHINXOPTS) -b html doc/source 
$(CURDIR)/debian/cloudkitty-doc/usr/share/doc/cloudkitty-doc/html || rm -rf 
$(CURDIR)/debian/cloudkitty-doc/usr/share/doc/cloudkitty-doc/html
        dh_sphinxdoc -O--buildsystem=python_distutils
 endif
 
@@ -61,6 +61,7 @@
                --namespace oslo.middleware.cors \
                --namespace oslo.policy \
                --namespace keystonemiddleware.auth_token
+       sed -i -e 's@^\(#host = \).*@\1@g' 
$(CURDIR)/debian/cloudkitty-common/usr/share/cloudkitty-common/cloudkitty.conf
 
        for i in api_paste.ini policy.json ; do \
                install -D -m 0664 etc/cloudkitty/$$i 
$(CURDIR)/debian/cloudkitty-common/usr/share/cloudkitty-common/$$i ; \

Reply via email to