Control: tags -1 + confirmed

On Sun, Jan 14, 2018 at 08:03:41PM +0100, Helmut Grohne wrote:
> Package: debootstick
[...]
> /usr/share/debootstick/scripts/create-image/functions contains dumpe2fs, 
> mkfs.ext4 and resize2fs. According to file it is a ASCII text

dumpe2fs and resize2fs are only mentioned in comments.
Only mkfs.ext4 is actually used in the codes make_root_fs() function.

The make_root_fs function is called from create_formatted_image()
(in the same file), and the create_formatted_image function is called
twice unconditionally in the main debootstick script.

(For comparison mkfs.vfat is also used in the same file and dosfstools
is already listed in depends.)

> /usr/share/debootstick/scripts/live/init/migrate-to-disk.sh contains 
> resize2fs. According to file it is a Bourne-Again shell script, ASCII text 
> executable
> /usr/share/debootstick/scripts/live/init/occupy-space.sh contains resize2fs. 
> According to file it is a POSIX shell script, ASCII text executable
[...]

It seems both of the above files actually uses resize2fs.
(No deeper analysis given the previous file already seem to have
made it clear mkfs.ext4 from e2fsprogs is crutial.)

My conclusion is thus that a dependency on e2fsprogs should be added.

Would be great to hear from maintainers on this... Even if it's just to
say that an NMU to take care of this would be appreciated.


Regards,
Andreas Henriksson

Reply via email to