On Sun, Jan 14, 2018 at 08:11:17PM +0100, Helmut Grohne wrote:
> Package: sbuild
[...]
> /usr/share/sbuild/create-chroot contains mkfs.ext4 and tune2fs. According to 
> file it is a Bourne-Again shell script, ASCII text executable
[...]

The create-chroot script uses the mkfs.ext4 and tune2fs commands if and
only if the script is called with the optional volume-group argument
specified.

I can not find any other part of sbuild that calls the create-chroot
script.

I'm not sure what the rationale is for installing the script in the
location where it's shipped (rathen than just putting it in /usr/sbin
or similar).

https://anonscm.debian.org/cgit/buildd-tools/sbuild.git/commit?id=18512e3303f56a55841719e393c3e5a4653c9b70

https://anonscm.debian.org/cgit/buildd-tools/sbuild.git/commit/bin/create-chroot?h=debian/unstable&id=f5c642e0786356ccb58d141dda0dbebf0778227a


https://anonscm.debian.org/cgit/buildd-tools/sbuild.git/commit/bin/create-chroot?h=debian/unstable&id=1dff84941e8294158a1a4346996556d39bcf8d3c

https://anonscm.debian.org/cgit/buildd-tools/sbuild.git/commit?h=debian/unstable&id=a0b923fccf6fea35becb330b47ccd14b9d36b012

Please note that there's also a completely separate sbuild-createchroot
command which seems to do a similar job. (Maybe 'create-chroot' is an
ancient leftover kept around for legacy reasons?)

My conclusion is that a dependency on e2fsprogs is likely not strictly
needed. A Recommends or Suggests might be considered, but given
e2fsprogs will be installed in *any* system except where the admin
has explicitly uninstalled it, I think that gives very little benefit.

It would be great to hear from maintainers on this!

Regards,
Andreas Henriksson

Reply via email to