On 2/27/06, Giacomo A. Catenazzi <[EMAIL PROTECTED]> wrote:
> > Note: I din't understood what has changed, but the test for the
> > existance of sleep should not miss as it would break the whole
> > download script instead of gracefully failing ;-)
>
> I don't understand.
> It would write an error message every at sleep message
> (OK, not the right thing to do).
> So I think a test at the beginning of the (nested) script
> would be better. And the eventually (but single) error message
> is correct, so that user see that it want to use sleep (via option),
> but sleep doesn't exits.

Ok, now is clear; I was pointing out that there should be a test.

> > type is present in the specification (not sure if this implies that is
> > POSIX) - see "Utilities" in "Shel&Utilities".
>
> oops. I didn't see it.
>
> >
> >> So I would apply any your solution that works on normal case.
> > Only the sleep period issue should be fixed first.
> > Have you made any changes from the zip you send previously?
>
> No, no further changes.

Would you like to make the changes for the sleep period to be always
defined? I will have access to the code only this evening, so the
patch would be available only tomorrow.

BTW: do you have some tests frame you run for apt-zip? It would be
nice to have that.

And another thing, do you have a svn/dracs/arch/... repository where
you keep the apt-zip source? I have my own copy in my own SVN repo,
but it would be nice to have a common one, I guess. (WIth some luck I
will have it public sometime during the next week, depending on the
seriosity of my ISP and the time I will have). Or we could use alioth?

--
Regards,
EddyP
=============================================
"Imagination is more important than knowledge" A.Einstein

Reply via email to