On Tue, Apr 17, 2018 at 08:03:41PM +0100, Chris Lamb wrote:
> Attached is the following:
> 
>   commit f8d976951e4728b4a34ac8e04bd50d6e59b82634
>   Author: Chris Lamb <la...@debian.org>
>   Date:   Tue Apr 17 20:02:41 2018 +0100
>   
>       reproducible Debian: Correct parsing of diffoscope version since recent 
> update of PyPI.org
>   
>    bin/diffoscope_distribution_test.sh | 4 ++--
>    1 file changed, 2 insertions(+), 2 deletions(-)

Thanks, applied!

> -     curl https://pypi.python.org/pypi/diffoscope/ -o $TMPPYPI
> -     DIFFOSCOPE_IN_PYPI=$(grep "<title>" $TMPPYPI | cut -d ">" -f2- | cut -d 
> ":" -f1 |cut -d " " -f2)
> +     curl https://pypi.org/project/diffoscope/ -o $TMPPYPI
> +     DIFFOSCOPE_IN_PYPI=$(sed -ne 's@.*diffoscope \([0-9][0-9]*\).*@\1@gp' 
> $TMPPYPI)

Anyhow, I wonder if it wouldn't be cleaner to use pypi's API instead…
Maybe for the next time this regex breaks :)

-- 
regards,
                        Mattia Rizzolo

GPG Key: 66AE 2B4A FCCF 3F52 DA18  4D18 4B04 3FCD B944 4540      .''`.
more about me:  https://mapreri.org                             : :'  :
Launchpad user: https://launchpad.net/~mapreri                  `. `'`
Debian QA page: https://qa.debian.org/developer.php?login=mattia  `-

Attachment: signature.asc
Description: PGP signature

Reply via email to