Hi,
On Wed, Apr 18, 2018 at 05:36:13PM +0200, Raphaël Halimi wrote:
> Le 18/04/2018 à 08:45, Guido Günther a écrit :
> > Check _kernelFetchHelper where it adds the method arg. I doubt this is
> > needed at all on Debian but rather a leftover of other distros.
>
> Hi again,
>
> Thanks to your hint, and after a bit of fiddling (remember I don't know
> python), I came up with the simple patch attached.
>
> It implements the second solution (remove "method=" altogether if the
> distribution is detected as "Debian").
>
> It should be tested with other guest distributions though.
>
> Also, I think you could also check if self.name is equal to "Ubuntu",
> but I'm not sure if ubuntu-installer needs (or support) "method=" or not.
>
> Do you want me to create and forward a bug upstream ?
That's a good start. Please forward this upstream (the actual fix will
likely have to be in a slightly different location)
Cheers
-- Guido
>
> Regards,
>
> --
> Raphaël Halimi
> --- /usr/share/virt-manager/virtinst/urlfetcher.py.orig 2017-09-14
> 23:49:00.000000000 +0200
> +++ /usr/share/virt-manager/virtinst/urlfetcher.py 2018-04-18
> 17:29:08.902639187 +0200
> @@ -661,7 +661,8 @@
> args = ''
>
> if not self.fetcher.location.startswith("/"):
> - args += "%s=%s" % (self._get_method_arg(), self.fetcher.location)
> + if self.name != "Debian":
> + args += "%s=%s" % (self._get_method_arg(),
> self.fetcher.location)
