On Thu, Apr 19, 2018 at 04:02:12PM +0200, Michael Biebl wrote:
> Am 19.04.2018 um 11:06 schrieb Debian Bug Tracking System:
> >  sugar (0.112-4) unstable; urgency=medium
> >  .
> >    * Stop depending on gir1.2-nmgtk-1.0 (Closes: #857230)
> 
> Hm, you dropped the dependency, but I don't think this is actually a
> proper fix, as I still see this in the code:
> 
> $ grep import -R | grep NM
> extensions/cpsection/network/model.py:from gi.repository import NMClient
> 
> I.e., sugar still uses the old libnm-glib based GIR bindings (
> gir1.2-networkmanager-1.0 to be precise).

Agreed.

> The code should be ported to use gir1.2-nm-1.0, the libnm based GIR
> bindings.

Takes longer to talk about it than do it.  ;-)

Nobody told upstream.  Upstream has ported now.  You may cherry-pick.

https://github.com/sugarlabs/sugar/commit/04c63f6dd2b6f10a80376a43c735822f5283bda7

For your interest, neither the new nor the old API actually works on
recent Debian or Ubuntu; silently failing.

https://github.com/sugarlabs/sugar/issues/794

-- 
James Cameron
http://quozl.netrek.org/

Reply via email to