Control: reassign -1 vinagre Control: found -1 3.22.0-5
Hi,I had more chat exchange with upstream and we both did some tests in Debian sid VMs with vinagre and freerdp2.
On Mi 16 Mai 2018 00:11:53 CEST, Josh Triplett wrote:
reopen 898448 thanks I can still reproduce this segfault with the patched libfreerdp2-2 in current unstable.
akallabeth from FreeRDP2 posted on the upstream tracker: ```found the issue, looks like vinagre does session disconnect regardless of connection state. The behaviour slightly changed since freerdp `1` and was buggy for quite some time in `2` (which is why this might have gone unnoticed)
``` And on IRC: ```11:34 < _akallabeth_> sunweaver: hmm, interesting, getting segfaults in different areas with a fresh debian sid 11:35 < _akallabeth_> sunweaver: starts to smell like there is something wrong in vinagre too
11:52 < _akallabeth_> sunweaver: ah, got it.11:54 < _akallabeth_> looks like freerdp_disconnect is called regardless of connection success state 11:59 < _akallabeth_> sunweaver: so that calls freerdp_disconnect twice (once to clean up resources in connect and another time afterward) 12:03 < _akallabeth_> same for gdi_init/gdi_free, that is handled optimistic in vinagre (post disconnect may never fail, not even the library internals)
```In vinagre, the gdi_free and context_disconnect functions should only be called if there is something to disconnect or to free...
Thus, reassigning to vinagre with this message. Thanks! Hope that helps, Mike -- DAS-NETZWERKTEAM mike gabriel, herweg 7, 24357 fleckeby mobile: +49 (1520) 1976 148 landline: +49 (4354) 8390 139 GnuPG Fingerprint: 9BFB AEE8 6C0A A5FF BF22 0782 9AF4 6B30 2577 1B31 mail: mike.gabr...@das-netzwerkteam.de, http://das-netzwerkteam.de
pgp2ELUtLhpwp.pgp
Description: Digitale PGP-Signatur
