Thanks for having a look at our patches! On 16.05.2018 05:45, oiaohm wrote: > https://sources.debian.org/patches/wine/3.0-1/font-divbyzero.patch/ > > If you read the associated wine bug > https://bugs.winehq.org/show_bug.cgi?id=38762 > > The divide by zero issue was in fact fixed in freetype 2.6.2 . The > changing of the scale value to 1 end up not copying windows behavior > where face->size.height == 0 equals font not display. So its not a > error to have face->size.height==0. > > So this should be set min version of freetype greater than where the > patch was added and that is freetype 2.6.2 and this suitable for > stable, testing and sid. > > Thing to remember there are third party fonts out there with stupid > metrics so the correct place to address the font divide by zero > problem was always freetype. > > I can see that min version of freetype has not been updated as libwine > is packages are still with libfreetype6 (>= 2.2.1) instead of > libfreetype6 (>= 2.6.2) as required to address this issue properly > without the patch.
We discussed that some time before (you'll find the full discussion in https://lists.debian.org/debian-wine/): On Wed, Aug 31, 2016 at 2:29 PM, Jens Reyer wrote: On 13.09.2016 02:47, Michael Gilbert wrote: >> font-divbyzero.patch >> description: avoid divide-by-zero condition for certain font files and >> warn about it >> bug: https://bugs.winehq.org/show_bug.cgi?id=38762 >> bug-debian: https://bugs.debian.org/788809 >> >> The problematic font has been fixed, and the situation should have >> improved with freetype >= 2.6.2. >> I'd suggest to drop this patch now. > > Division by zero shouldn't be tolerated. It should be upstreamed. Given that stable has a newer freetype, that the specific font is fixed, and that upstream hasn't acted on the bugreport (although nobody submitted the patch officially) I'd personally agree that we can drop this patch. To get this fixed upstream the next step is to check what Windows does (e.g. if Windows crashes, Wine is supposed to also crash). About increasing the minimum freetype version: this shouldn't be done "just" because of a bug. Reason for this (afaik) is because it has wide consequences, e.g. for using the package in another Debian version or another distribution. Since this is just a minor issue I'd advise against increasing it. Greets jre
