Hi! On Sat, 2018-06-02 at 08:32:27 +0200, Sven Joachim wrote: > On 2018-04-20 01:24 +0200, Guillem Jover wrote: > > On Tue, 2018-04-03 at 12:39:54 +0100, Colin Watson wrote: > > > Maybe -lbsd should be moved to Libs.private? But I don't know the > > > libedit interface in detail, and in any case this is up to the libedit > > > maintainers, so reassigning. > > > > I think so, yes. This seems like an actual regression from upstream, > > because the patch to switch it to use libbsd which I sent and got > > carried for a while in Debian was using Requires.private. > > In version 3.1-20180525 -lbsd (and -lncurses) was moved back to > Libs.private, and openssh-client no longer depends on libbsd0 when I > rebuild it. > > However, is linking libedit with -lbsd necessary at all on a recent > glibc version? At least dpkg-shlibdeps warns that libedit does not use > any of libbsd's symbols.
Ah! To avoid embedded code copies, yes, it is. I just checked and the problem is that the PKG_CHECK_MODULES call is too late, and the subsequent checks do not see that the symbols are already provided by libbsd, and then it embeds its own copies. This applies for strlcat, strlcpy, vis/unvis and fgetln. I'll send the patch I've got fixing this, once I've updated the symbols file. Thanks, Guillem
